feat: Modernize Docker Compose File #7086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isso-719
changed the title
|
It seems that docker-compose is still an alias of docker compose in the new version. Let's keep it for better compatibility. |
isso-719
force-pushed
the
feature/isso/rename-docker-compose
branch
from
77c4348
to
5793f0f
Compare
@jinzhu Please check Files changed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did this pull request do?
This pull request did the following
Changed command used fromdocker-composetodocker compose.Change related files.Rename the file from docker-compose.yml to compose.yml .
The file name
compose.ymlis preferred.https://docs.docker.com/compose/compose-application-model/#the-compose-file
Remove version top-level element on compose.yml .
Version top-level element is obsoleted.
https://docs.docker.com/compose/compose-file/04-version-and-name/#version-top-level-element-obsolete
When run test, system shows warning.
tests % ./tests_all.sh WARN[0000] /Users/john/gorm/tests/docker-compose.yml: `version` is obsolete ...Changed command used from
docker-composetodocker compose.The recommended command-line syntax is
docker compose.https://docs.docker.com/compose/migrate/#what-are-the-differences-between-compose-v1-and-compose-v2
Change related files.
docker-compose start=>docker compose startdocker-compose up=>docker compose upUser Case Description