Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gles2 tag to support using ANGLE (EGL OpenGLES2) on windows #113

Merged
merged 1 commit into from
Mar 6, 2021
Merged

Add gles2 tag to support using ANGLE (EGL OpenGLES2) on windows #113

merged 1 commit into from
Mar 6, 2021

Conversation

zwang
Copy link
Contributor

@zwang zwang commented Mar 5, 2021 •
edited
Loading

while still keep the Desktop OpenGL option default for windows.

With this change, the go-gl/gl binding can use EGL OpenGL ES2 as an option by passing egl and gles2 tags. (using ANGLE project)

Without these tags, it can still use the default desktop OpenGL as before

Should help on: #51

@zwang
Add gles2 tag to allowing using ANGLE (EGL OpenGLES2) on windows
0a9cc62 
still keep the Desktop OpenGL option default for windows
@zwang zwang changed the title Add gles2 tag to allowing using ANGLE (EGL OpenGLES2) on windows Add gles2 tag to support using ANGLE (EGL OpenGLES2) on windows Mar 5, 2021
@errcw
Copy link
Member

errcw commented Mar 5, 2021

I'm curious why the "2" in the gles2 tag? As I understand it, ANGLE supports both GLES 2.0 and 3.x?

@zwang
Copy link
Contributor Author

zwang commented Mar 5, 2021 •
edited
Loading

Yeah, that's true. gles can works too.

I think I was in the mindset that I was fixing for OpenGL ES 2 and also the library from angle is libGLESv2.dll. Also I saw this tag is already being used in go-gl/glfw repo for linux,gles2

From another perspective, gles2 also can mean OpenGL ES 2 and above, which differentiates from OpenGL ES 1. Nobody should be using OpenGL ES 1 at this moment. But using gles might indicate it support OpenGL ES 1 too.

I am OK to change. But I prefer to keep this gles2 to be consistent with other places in GLFW.

Maybe should add gles3 too if we want to make it cover OpenGL ES 3.x

@errcw
Copy link
Member

errcw commented Mar 6, 2021

Thanks for thinking this through! I agree consistency is a good argument.

@errcw errcw merged commit b197509 into go-gl:master Mar 6, 2021
@zwang zwang deleted the gles2 branch March 6, 2021 04:33
@zwang zwang mentioned this pull request Mar 6, 2021
Merged
errcw pushed a commit to go-gl/gl that referenced this pull request Mar 8, 2021
@zwang
Support egl and gles2 tags on windows (#133)
640c646 
to support using EGL   Desktop OpenGL and EGL OpenGLES2(ANGLE) on windows

Cover latest glow changes and the change in the two PR below
go-gl/glow#112
go-gl/glow#113

Co-authored-by: Zhao Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zwang @errcw