Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-736: moving validation of one-time to #737

Conversation

rbroggi
Copy link
Contributor

@rbroggi rbroggi commented Jun 20, 2024

What does this do?

Which issue(s) does this PR fix/relate to?

Resolves #736

List any changes that modify/break current functionality

Have you included tests for your changes?

Yes

Did you document any new/modified functionality?

  • Updated example_test.go
  • Updated README.md

Notes

@rbroggi
Copy link
Contributor Author

rbroggi commented Jun 20, 2024

the failed tests seem to be deriving from test-flakiness that is not linked to this change...

Copy link
Contributor

@JohnRoesler JohnRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is exactly what I was thinking 👍

@JohnRoesler JohnRoesler merged commit fd18ca7 into go-co-op:v2 Jun 20, 2024
4 checks passed
@rbroggi rbroggi deleted the issue-736-support-internal-scheduler-clock-for-one-time-job-validation branch June 21, 2024 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - OneTimeJobStartDateTime returns error if date in the past
2 participants