Add AfterJobRunsWithPanic
#733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnRoesler
requested changes
Jun 18, 2024
There was a problem hiding this comment.
hey @trungdlp-wolffun thanks for working on this!
I think the concept would fit nicely as another EventListener. EventListeners can be added to a single Job using WithEventListeners, as well as for the entire scheduler using WithGlobalJobOptions.
You could model it after AfterJobRunsWithError, but call it AfterJobRunsWithPanic.
trungdlp-wolffun
changed the title
AfterJobRunsWithPanic
|
@JohnRoesler I changed it to the EventListener: AfterJobRunsWithPanic, you can review it now |
JohnRoesler
reviewed
Jun 19, 2024
| _ = callJobFuncWithParams(j.afterJobRunsWithPanic, j.id, j.name, recoverData) | ||
|
|
||
| // if panic is occurred, we should return an error | ||
| err = ErrPanicRecovered |
There was a problem hiding this comment.
Is this error ever readable by the caller? Seems ineffectual. But I could be wrong 😁
There was a problem hiding this comment.
The caller can catch this error via an EventListener
WithEventListeners(
AfterJobRunsWithError(
func(jobID uuid.UUID, jobName string, err error) {
if errors.Is(err, gocron.ErrPanicRecovered) {
// ....
}
},
),
),
JohnRoesler
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Which issue(s) does this PR fix/relate to?
Resolves #732
List any changes that modify/break current functionality
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
example_test.goREADME.mdNotes