Feat: add explicit 'Duration=' parameter to EXT-X-CUE-OUT #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leandromoreira
suggested changes
May 9, 2024
m3u8/model.py
Outdated
| @@ -629,7 629,7 @@ def dumps(self, last_segment, timespec="milliseconds"): | |||
|
|
|||
| output.append( | |||
There was a problem hiding this comment.
I think we should preserve what the what we receive as input.
Meaning, we should expand the parser to include something like cue_out_duration_property to true.
elif line.startswith(protocol.ext_x_cue_out):
_parse_cueout(line, state)
state["cue_out_start"] = True
state["cue_out"] = True
if line.contains(somethingsomething):
state["cue_out_explicitly_duration"] = TrueAnd then here, we would need to check to see if we'd need to add the Duration or not. WDYT?
There was a problem hiding this comment.
Otherwise we'll transform manifests without Duration to have one.
There was a problem hiding this comment.
Yeah, that's true. I changed it and adapted for parsing it only when DURATION is available.
Also, a new test has been created and some code has been refactored regarding the new state.
leandromoreira
approved these changes
May 9, 2024
mauricioabreu
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have been investigating the problem with DURATION parameters.
Firstly, as you already know it isn't compulsory to establish the parameter as you can see in an example where is use and other which not. The use of the parameter will depend on some key points:
#EXT-X-CUE-OUT:DURATION=195.000,BREAKID=103038I see the change as an improvement for the following reasons:
Regarding all, thank you for making the package and contributing to the open-source community.
A test has been changed for checking the new format