Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MediaConvert EXT-CUE-OUT-CONT still problematic #373

Closed
wabiloo opened this issue Jul 30, 2024 · 1 comment · Fixed by #374
Closed

MediaConvert EXT-CUE-OUT-CONT still problematic #373

wabiloo opened this issue Jul 30, 2024 · 1 comment · Fixed by #374

Comments

@wabiloo
Copy link

wabiloo commented Jul 30, 2024

Hi,
I still have problems with some HLS manifests generated by AWS MediaConvert, even after the fix to #349.
Here is an example: https://bpkio-cs-demos.s3-eu-west-1.amazonaws.com/fabre/mediaconvert-conditioning/output/hls/cts-laworder720p.m3u8

The lib fails on this line:
#EXT-X-CUE-OUT-CONT:10/4, SpliceType=VOD_DAI,Action=REPLACE,PAID=amazon.com/TEST2014020500000346,Acds=BA.

Note that this type of markup is coming straight from the (poor) AWS documentation at https://docs.aws.amazon.com/mediaconvert/latest/ug/example-esam-xml-manifest-conditioning.html
@bbayles
Copy link
Contributor

bbayles commented Jul 30, 2024

I'll take a shot at fixing this!

bbayles added a commit to bbayles/m3u8 that referenced this issue Jul 30, 2024
@bbayles
Issue globocom#373: MediaConvert-style EXT-X-CUE-OUT-CONT support
1763161
@bbayles bbayles mentioned this issue Jul 30, 2024
Merged
mauricioabreu pushed a commit that referenced this issue Jul 30, 2024
@bbayles @mauricioabreu
Issue #373: MediaConvert-style EXT-X-CUE-OUT-CONT support
bd51ed4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #373: Import EXT-X-CUE-OUT and EXT-X-CUE-OUT-CONT handling bbayles/m3u8
2 participants
@bbayles @wabiloo