-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use built-in ISO 8601 parsing #331
Comments
One thing to consider: if you do performance profiling, you'll find that date parsing is one of the slowest things this library does. The Right now it's easy to patch in I support dropping the |
According to the benchmarks on |
On a semi-related note, I added a PR for adding 3.12 to the list of tested versions and I noticed that |
Looks like this isn't a viable solution until Python 3.11 so I'm guessing this needs to wait |
FWIW, there is also the option of using |
I did another version of my PR that uses the built-in on 3.11 and later, but I really liked the idea of using the backports (for the consistent implementation and performance improvement), so I added that to the PR as well. Thanks for the suggestion! |
Continuing in the vein of #38, the built-in parsing of ISO 8601 that was added in Python 3.7 should be used. This would require bumping the minimum supported Python version, but 3.8 is the oldest version that's still supported, so that should be a fine thing to do. I'd be glad to submit a PR for this, if it will be accepted
The text was updated successfully, but these errors were encountered: