We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There's a problem in output_from_command (lib/graphviz/utils.rb) in the condition:
output_from_command
if (status.nil? && (errors.nil? || errors.strip.empty?)) || status.zero?
The method zero? crashes when status is nil, a situation which escapes the first half of the condition.
zero?
One correct way to write it would be:
if (status.nil? && (errors.nil? || errors.strip.empty?)) || 0 == status
I know I should do this as a pull request, but for just a few characters it doesn't seem worth it. Maybe someone in the team can do it?
Thanks!
The text was updated successfully, but these errors were encountered:
No branches or pull requests
There's a problem in
output_from_command(lib/graphviz/utils.rb) in the condition:if (status.nil? && (errors.nil? || errors.strip.empty?)) || status.zero?The method
zero?crashes when status is nil, a situation which escapes the first half of the condition.One correct way to write it would be:
if (status.nil? && (errors.nil? || errors.strip.empty?)) || 0 == statusI know I should do this as a pull request, but for just a few characters it doesn't seem worth it. Maybe someone in the team can do it?
Thanks!
The text was updated successfully, but these errors were encountered: