Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-decorator exports are not exported in index.js, docs incorrect #152

Closed
rektide opened this issue May 26, 2021 · 0 comments
Closed

Non-decorator exports are not exported in index.js, docs incorrect #152

rektide opened this issue May 26, 2021 · 0 comments

Comments

@rektide
Copy link

rektide commented May 26, 2021

The attrs doc page, for example, says one can

import {initializeAttrs, defineObservedAttributes} from '@github/catalyst

However a look at index.ts shows this is not exported. Trying to run these examples fails.
@koddsson koddsson mentioned this issue May 28, 2021
Merged
jauntywunderkind added a commit to jauntywunderkind/catalyst that referenced this issue Jul 4, 2021
@jauntywunderkind
add exports for non-decorator usage to index.ts. fixes github#152.
8819601
koddsson added a commit that referenced this issue Jul 19, 2021
@koddsson
Merge pull request #153 from jauntywunderkind/export-star
a5d05b9 
export functions needed for non-Decorator users. fixes #152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rektide