Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trimming whitespaces from url while cloning (Fixes #952) #965

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Trimming whitespaces from url while cloning (Fixes #952) #965

merged 1 commit into from
Jan 30, 2024

Conversation

prostolyubo
Copy link
Contributor

@prostolyubo prostolyubo commented Jan 30, 2024 •
edited
Loading

Added in CloneWindowController.m a trimming operation before passing contents of a text field into GitUpKit
Fixes #952

@prostolyubo
Trimming whitespaces from url while cloning (git-up#952)
c4fb1fb 
Added in CloneWindowController.m a trimming operation before passing contents of a text field into GitUpKit
@prostolyubo prostolyubo changed the title Trimming whitespaces from url while cloning (#952) Trimming whitespaces from url while cloning (Fixes #952) Jan 30, 2024
@richardtop
Copy link

Thanks

lucasderraugh
lucasderraugh approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@lucasderraugh lucasderraugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for picking that up.

@lucasderraugh lucasderraugh merged commit 477ce37 into git-up:master Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasderraugh lucasderraugh lucasderraugh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Trim space characters in the clone bar
3 participants
@prostolyubo @richardtop @lucasderraugh