-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors encountered during rendering do not assign the type ErrorTypeRender #3954
Comments
I checked the relevant functions and submission history. This method is quite old and modifications may have a greater impact. |
@RedCrazyGhost I don't see any impact, just update following code:
replace with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In summary, ErrorTypeRender does not appear to be used anywhere in the code.
We discovered this issue when we were having marshalling failures in
context.JSON()
. We tried checkingcontext.Errors
for errors with typeErrorTypeRender
, and realised that nowhere in the code is that set.Could open a PR for this but wanted to confirm if it was intended or not, since ErrorTypes are super old. I could not find any thread or issue that would suggest it though.
How to reproduce
Expectations
The test code should print true, since the error was occurred during rendering.
Actual result
The test code prints false.
Environment
The text was updated successfully, but these errors were encountered: