Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I hope you can set the zip file comment #502

Closed
nijinekoyo opened this issue Apr 3, 2024 · 2 comments
Closed

I hope you can set the zip file comment #502

nijinekoyo opened this issue Apr 3, 2024 · 2 comments

Comments

@nijinekoyo
Copy link

I did not find the comment configuration in the ZipWriterConstructorOptions type. Currently I can only set the comment of each file in zipWriter.add(). I hope to set a single zip in new ZipWriter() comment of the file
@bwbroersma
Copy link
Contributor

See ZipWriter close, the optional first argument is the comment for the EOCD:

zip.js/lib/core/zip-writer.js

Lines 201 to 203 in 7021dd3

close(comment = undefined, options = {}) {
return this.zipWriter.close(comment, options);
}

zip.js/lib/core/zip-writer.js

Line 163 in 7021dd3

async close(comment = new Uint8Array(), options = {}) {

@nijinekoyo
Copy link
Author

See ZipWriter close, the optional first argument is the comment for the EOCD:

zip.js/lib/core/zip-writer.js

Lines 201 to 203 in 7021dd3

close(comment = undefined, options = {}) {
return this.zipWriter.close(comment, options);
}

zip.js/lib/core/zip-writer.js

Line 163 in 7021dd3

async close(comment = new Uint8Array(), options = {}) {

That's it, thanks

Repository owner locked and limited conversation to collaborators Apr 6, 2024
@gildas-lormeau gildas-lormeau converted this issue into discussion #503 Apr 6, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bwbroersma @nijinekoyo