Reintroduce computepass->encoder lifetime constraint and make it opt-out via wgpu::ComputePass::forget_lifetime
#5768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…out via `wgpu::ComputePass::make_static`
Wumpf
commented
Jun 2, 2024
kpreid
reviewed
Jun 2, 2024
Wumpf
force-pushed
the
make-static-computepass
branch
from
1f56788
to
b147e8c
Compare
Wumpf
force-pushed
the
make-static-computepass
branch
from
b147e8c
to
df6f891
Compare
kpreid
reviewed
Jun 2, 2024
Wumpf
changed the title
wgpu::ComputePass::make_staticwgpu::ComputePass::forget_lifetime
|
thanks again, I'm much happier with this now! |
kpreid
approved these changes
Jun 2, 2024
|
AFAICT, controls to |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
RenderPassmake it difficult to use. #1453ComputePassto its parent command encoder #5620Description
As suggested on Matrix chat by @kpreid.
In #5620,
wgpu::ComputePasslost its explicit lifetime constraint towgpu::CommandEncoder. This constraint prevented use of the command encoder while a pass is recorded. This is still an error, but now a runtime error. While removing this lifetime is very useful especially for library authors, it also prevented trivial incorrect api usage, i.e. that PR was great but also created a massive footgun ;-).Here, we remedy this issue by re-introducing the exact same lifetime constraint but making it opt-out with a zero-overhead
forget_lifetimemethod.Testing
Existing tests have been adjusted - compilation failed as expected without these adjustments!
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.