Fix regression on OpenGL (EGL) where non-sRGB still used sRGB #5642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can confirm that this fixes the issue I reported. :) |
Wumpf
approved these changes
May 3, 2024
vorporeal
pushed a commit
to warpdotdev/wgpu
that referenced
this pull request
May 9, 2024
Wumpf
pushed a commit
to Wumpf/wgpu
that referenced
this pull request
May 18, 2024
ErichDonGubler
pushed a commit
that referenced
this pull request
May 18, 2024
jimblandy
pushed a commit
to jimblandy/wgpu
that referenced
this pull request
May 23, 2024
waywardmonkeys
added a commit
to waywardmonkeys/vello
that referenced
this pull request
Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding versions (which are 0.21.x). This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812 It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642
waywardmonkeys
added a commit
to waywardmonkeys/vello
that referenced
this pull request
Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding versions (which are 0.21.x). This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812 It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642
github-merge-queue bot
pushed a commit
to linebender/vello
that referenced
this pull request
Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding versions (which are 0.21.x). This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812 It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642
DJMcNab
pushed a commit
to DJMcNab/vello
that referenced
this pull request
Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding versions (which are 0.21.x). This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812 It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642
DJMcNab
pushed a commit
to linebender/vello
that referenced
this pull request
Jul 16, 2024
This also updates `wgpu-core` and `wgpu-hal` to the corresponding versions (which are 0.21.x). This fixes some undefined behavior when building with Rust 1.79 and using the Direct3D 12 backend: gfx-rs/wgpu#5812 It also fixes an issue on OpenGL where non-sRGB was still using sRGB: gfx-rs/wgpu#5642
morr0ne
pushed a commit
to morr0ne/wgpu
that referenced
this pull request
Jul 28, 2024
cwfitzgerald
removed
the
PR: needs back-porting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
#5639
Description
Its probably worth to also include it in a patch release.
Testing
Setting https://github.com/gfx-rs/wgpu/blob/trunk/examples/src/framework.rs#L13 (SRGB) to false, and it should use the non-srgb view format, and therefore look darker.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.