[naga xtask] Minor simplifications. #4883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer nested `fn` functions over closures when possible. Using a `fn` makes it evident that no values are being captured. Simplify HLSL loop over entry points.
ErichDonGubler
added
the
area: infrastructure
|
Looks like this review only needs another @gfx-rs/naga reviewer, but @teoxoy is out. Any objection to me force-merging, @jimblandy? This is a teeny change, and I expect negligible risk for |
|
bump @teoxoy :) |
|
LGTM but it seems it needs to now be rebased. |
|
This PR has been completely invalidated by #4902. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefer nested
fnfunctions over closures when possible. Using afnmakes it evident that no values are being captured.Simplify HLSL loop over entry points.
@ErichDonGubler These are purely style things - if you don't think the new code is more legible, feel free to reject the PR. I just wrote the changes in the process of understanding the code, and figured I might as well see whether anyone else felt similarly.
Checklist
cargo fmt.cargo clippy.cargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.