Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wgpu-core] request_adapter fails when requesting with a specific backend #5289

Closed
rajveermalviya opened this issue Feb 22, 2024 · 4 comments · Fixed by #5535
Closed

[wgpu-core] request_adapter fails when requesting with a specific backend #5289

rajveermalviya opened this issue Feb 22, 2024 · 4 comments · Fixed by #5535
Labels
type: bug Something isn't working

Comments

@rajveermalviya
Copy link
Contributor

Description
Instance::request_adapter fails when instance is created with Backends::all(), and then a surface is initialized, and then request_adapter is called with a specific backend in an environment with 2 or more backends.

Repro steps

  1. Ensure you have two or more different backends.
  2. Update instance_request_adapter to pass a single backend like wgt::Backends::DX12/VULKAN/METAL instead of wgt::Backends::all().
  3. Run the hello_triangle example
  4. Notice request_adapter fails, if it doesn't fail then cycle through other available backends on Step 2.

Expected vs observed behavior
request_adapter should succeed

Platform
macOS 14, Metal MoltenVK
rajveermalviya added a commit to rajveermalviya/wgpu-native that referenced this issue Feb 24, 2024
@rajveermalviya
Add workaround for gfx-rs/wgpu#5289
20a12ae
This was referenced Feb 24, 2024
Merged
Open
rajveermalviya added a commit to gfx-rs/wgpu-native that referenced this issue Feb 26, 2024
@rajveermalviya
Add workaround for gfx-rs/wgpu#5289 (#372)
bcdca75
@teoxoy teoxoy added the type: bug Something isn't working label Feb 27, 2024
@rajveermalviya
Copy link
Contributor Author

Closing as seems to be dupe of #5324, which will be fixed by #5535

@Wumpf
Copy link
Member

Wumpf commented Apr 15, 2024

@rajveermalviya thanks for following up, did you confirm using the branch from #5535 that it fixes the issue for you? :)
(seems very likely indeed, but might be nice to have the extra datapoint :))

@rajveermalviya
Copy link
Contributor Author

@Wumpf Yes, I confirmed that #5535 fixes the issue on at least MoltenVK Metal setup (I haven't tested it on other platforms).
Thanks for working on it! :)

@Wumpf
Copy link
Member

Wumpf commented Apr 15, 2024

excellent, thank you!

@Wumpf Wumpf mentioned this issue Apr 15, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix surfaces only compatible with first enabled backend Wumpf/wgpu
3 participants
@Wumpf @teoxoy @rajveermalviya