Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NV12 Vulkan CI Errors #4825

Closed
cwfitzgerald opened this issue Dec 4, 2023 · 0 comments · Fixed by #4832
Closed

NV12 Vulkan CI Errors #4825

cwfitzgerald opened this issue Dec 4, 2023 · 0 comments · Fixed by #4832
Labels
api: vulkan Issues with Vulkan type: bug Something isn't working

Comments

@cwfitzgerald
Copy link
Member

CI is now running into after a mesa update:

Validation Error: [ VUID-VkImageCreateInfo-pNext-06722 ] | MessageID = 0x1a04b807 | vkCreateImage(): pCreateInfo->pNext<VkImageFormatListCreateInfo>.pViewFormats[0] (VK_FORMAT_R8_UNORM) and VkImageCreateInfo::format (VK_FORMAT_G8_B8R8_2PLANE_420_UNORM) are not compatible. The Vulkan spec states: If a VkImageFormatListCreateInfo structure was included in the pNext chain and VkImageFormatListCreateInfo::viewFormatCount is not zero, then each format in VkImageFormatListCreateInfo::pViewFormats must either be compatible with the format as described in the compatibility table or, if flags contains VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT, be an uncompressed format that is size-compatible with format

Looking at this table, I don't think it's valid to pass the plane formats as view_formats. The plane functionality is similar to the existing aspect functionality used for combined depth-stencil textures where the format specified for the view is the format of one of the planes/aspects.

I think it would have made sense to add variants for the planes to TextureAspect rather than the new plane param.

Originally posted by @teoxoy in #4573 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: vulkan Issues with Vulkan type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

vulkan: fix multi-planar texture creation xiaopengli89/wgpu
1 participant
@cwfitzgerald