ROCm/HIP #452
ROCm/HIP #452
Conversation
|
When this is ready for review, would you mind rebasing? I want a guinea pig for the new Github Actions |
|
@davidjharder Since this change is pretty easy to rebase, feel free to ping me on Matrix if you need me to do it a few more times. |
|
Rebase now and the checks should work as expected |
|
Hey, can you rebase this again to try the check |
Signed-off-by: Gavin Zhao <[email protected]>
|
@davidjharder Done. |
| compilation target. | ||
| !--> | ||
|
|
||
| ROCm is designed such that in order for a library to support N different GPU |
There was a problem hiding this comment.
This is a wall of text, nobody will read this.
With that being said, is it even necessary to mention all of this? I mean, for end users what matters is whether the GPU architecture is supported or not: If it's supported, they'll continue their day without reading everything; if it's not supported, they'll reach out using the available support channels.
| ROCm is designed such that in order for a library to support N different GPU | |
| :::tip | |
| Install and run `rocminfo` to see your GPU architecture. | |
| ::: | |
| The ROCm package included in Solus supports the following GPU architectures out of the box: | |
| - `gfx803` | |
| - `gfx900` | |
| - `gfx906` | |
| - `gfx908` | |
| - `gfx90a` | |
| - `gfx1010`. This architecture can run programs compiled for `gfx101*` GPUs such as `gfx1011` and `gfx1012`, see [Emulating | |
| as a Supported Architecture](#emulating-as-a-supported-architecture). | |
| - `gfx1030`. This architecture can run programs compiled for `gfx103*` GPUs such as `gfx1031` and `gfx1032`, see [Emulating | |
| as a Supported Architecture](#emulating-as-a-supported-architecture). | |
| - `gfx1010` | |
| - `gfx1011` | |
| - `gfx1012` | |
| If your GPU is not on the list, please open an issue in our [issue tracker](https://github.com/getsolus/packages/issues/new/choose) with your GPU model and release year. | |
| This list is only the minimum supported architectures. Some packages like [Blender](#blender) support more architectures. |
| - `gfx1011` | ||
| - `gfx1012` | ||
|
|
||
| :::tip |
There was a problem hiding this comment.
Move this note to the top of the section (See my first comment for more info)
|
|
||
| ::: | ||
|
|
||
| :::note |
There was a problem hiding this comment.
This shouldn't be a note (See my first comment for more info)
|
|
||
| ::: | ||
|
|
||
| If your GPU model is not on the list, please open an issue in |
There was a problem hiding this comment.
Move this right after the GPU list.
| in PyTorch. | ||
|
|
||
| ## Install ROCm/HIP | ||
|
|
There was a problem hiding this comment.
Add an introductory sentence to this block:
| To install ROCm, execute the following command: |
| ### Emulating as a Supported Architecture | ||
|
|
||
| Several GPU archiectures, such as those in the Navi 1 family, have | ||
| almost identical (if not exactly identical) ISA that allows a program compiled for |
There was a problem hiding this comment.
Simplify this line:
| almost identical (if not exactly identical) ISA that allows a program compiled for | |
| similar ISAs. This allows programs compiled for |
|
|
||
| Several GPU archiectures, such as those in the Navi 1 family, have | ||
| almost identical (if not exactly identical) ISA that allows a program compiled for | ||
| one architecture to run seamlessly on other. |
There was a problem hiding this comment.
| one architecture to run seamlessly on other. | |
| one architecture to run on another. |
| the `gfx1031` and `gfx1032` architectures. A list of such architectures is | ||
| listed in the previous section. | ||
|
|
||
| To emulate your GPU as a supported architecture, the environment variable |
There was a problem hiding this comment.
| To emulate your GPU as a supported architecture, the environment variable | |
| To emulate your GPU as a supported architecture, add the `HSA_OVERRIDE_GFX_VERSION` environment variable to your system. For example: |
| almost identical (if not exactly identical) ISA that allows a program compiled for | ||
| one architecture to run seamlessly on other. | ||
| For example, any program compiled for the `gfx1030` architecture can also run on | ||
| the `gfx1031` and `gfx1032` architectures. A list of such architectures is |
There was a problem hiding this comment.
In general, it's not a good idea to say things like "the previous section" or "the previous step". Instead, refer to the specific section name and include a link to it.
| the `gfx1031` and `gfx1032` architectures. A list of such architectures is | |
| the `gfx1031` and `gfx1032` architectures. See the _Supported Hardware and GPU Architectures_ list for the supported architectures. |
|
@deoxys94 Thank you so much for your detailed review! I will address them later in the week. |
| ROCm is AMD's open-source software stack for GPU computation. | ||
|
|
||
| Note that ROCm is not required in order for, say, your display or browser, to | ||
| use GPU-acclerated rendering. These are more on the driver side of things and |
There was a problem hiding this comment.
| use GPU-acclerated rendering. These are more on the driver side of things and | |
| use GPU-accelerated rendering. These are more on the driver side of things and |
Other than this, spelling checks out
Description
Adds a section about how to use software that runs on or interacts with ROCm/HIP.
Submitter Checklist
git rebase -i(if needed)