client: Runbooks add an opt to fetch all runbooks or just runbooks owned

by a user
getsavvyinc · Nov 7, 2024 · b58c262 · b58c262
1 parent efb70e5
commit b58c262
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 7 deletions.
diff --git a/client/client.go b/client/client.go
@@ -17,7  17,7 @@ import (
 
 type RunbookClient interface {
 	RunbookByID(ctx context.Context, id string) (*Runbook, error)
-	Runbooks(ctx context.Context) ([]RunbookInfo, error)
 	Runbooks(ctx context.Context, opts RunbooksOpt) ([]RunbookInfo, error)
 }
 
 type RunbookSaver interface {
@@ -292,9  292,16 @@ func (c *client) RunbookByID(ctx context.Context, id string) (*Runbook, error) {
 	return &runbook, nil
 }
 
-func (c *client) Runbooks(ctx context.Context) ([]RunbookInfo, error) {
 type RunbooksOpt struct {
 	ExcludeTeamRunbooks bool
 }
 
 func (c *client) Runbooks(ctx context.Context, opts RunbooksOpt) ([]RunbookInfo, error) {
 	cl := c.cl
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, c.apiURL("/api/v1/list_runbooks/all"), nil)
 	if opts.ExcludeTeamRunbooks {
 		req, err = http.NewRequestWithContext(ctx, http.MethodGet, c.apiURL("/api/v1/list_runbooks"), nil)
 	}
 	if err != nil {
 		return nil, err
 	}

diff --git a/client/guest.go b/client/guest.go
@@ -116,12  116,12 @@ func (g *guest) RunbookByID(ctx context.Context, id string) (*Runbook, error) {
 	return &runbook, nil
 }
 
-func (g *guest) Runbooks(ctx context.Context) ([]RunbookInfo, error) {
 func (g *guest) Runbooks(ctx context.Context, opt RunbooksOpt) ([]RunbookInfo, error) {
 	cl, err := getLoggedInClient()
 	if err != nil {
 		return nil, err
 	}
-	return cl.Runbooks(ctx)
 	return cl.Runbooks(ctx, opt)
 }
 
 func (g *guest) Ask(ctx context.Context, question QuestionInfo) (*Runbook, error) {

diff --git a/client/local/local.go b/client/local/local.go
@@ -31,7  31,8 @@ func (l *local) RunbookByID(ctx context.Context, id string) (*client.Runbook, er
 	return rb, nil
 }
 
-func (l *local) Runbooks(ctx context.Context) ([]client.RunbookInfo, error) {
 // Runbooks returns all runbooks stored in the local  storage
 func (l *local) Runbooks(ctx context.Context, _ client.RunbooksOpt) ([]client.RunbookInfo, error) {
 
 	rbs, err := storage.Read()
 	if err != nil {

diff --git a/cmd/run.go b/cmd/run.go
@@ -218,7  218,7 @@ type selectableRunbook struct {
 
 func allowUserToSelectRunbook(ctx context.Context, logger *slog.Logger, cl client.RunbookClient) (string, error) {
 	l := logger.With("func", "allowsUserToSelectRunbook")
-	runbooks, err := cl.Runbooks(ctx)
 	runbooks, err := cl.Runbooks(ctx, client.RunbooksOpt{})
 	if err != nil {
 		l.Debug("failed to fetch runbooks", "error", err)
 		return "", err

diff --git a/cmd/sync.go b/cmd/sync.go
@@ -32,7  32,9 @@ func syncRunbooks(cmd *cobra.Command, args []string) {
 		return
 	}
 
-	runbookInfo, err := cl.Runbooks(ctx)
 	runbookInfo, err := cl.Runbooks(ctx, client.RunbooksOpt{
 		ExcludeTeamRunbooks: true,
 	})
 	if err != nil {
 		logger.Error("failed to fetch runbooks", "error", err)
 		return