use: scala-js-macrotask-executor as ExecutionContext #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #302
/resolves #302
re: your comment @fwbrasil
Kyo-Scheduler:scala-js-macrotask-executorasExecutionContexton JS platform #302 (comment)I think the artifacts were not published for non-js targets after
1.1.0. If we add this only under JS settings, all is well.Regarding build time, I think that was a bug potentially having to do with adding the dependency for all targets. For a full clean build of core, the build time is now 28s on my machine.
I also went ahead and updated this as the executor under kyoTest. Do you think we need a direct dependency under kyo-core? I think transitive should be okay...