fix io task runtime tracking #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwbrasil
commented
May 3, 2024
| @@ -49,7 49,7 @@ private[kyo] class IOTask[T]( | |||
| k.command match | |||
| case Promise(p) => | |||
| this.interrupts(p) | |||
| val runtime = (clock.currentMillis() - startMillis).toInt | |||
| val runtime = (clock.currentMillis() - startMillis this.runtime()).toInt | |||
There was a problem hiding this comment.
This scenario happens when the fiber/io task suspends because of an async boundary. Here, runtime should contain the time spent on the current execution plus all of the scheduling time the fiber got before it.
fwbrasil
commented
May 3, 2024
| @@ -12,7 12,7 @@ class Scheduler { | |||
|
|
|||
| def schedule(t: Task): Unit = { | |||
| JSExecutionContext.queue.execute { () => | |||
| if (t.run(0, clock) == Task.Preempted) | |||
| if (t.run(clock.currentMillis(), clock) == Task.Preempted) | |||
hearnadam
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug introduced by #278. I noticed it while testing the new scheduler under stress. I'm not sure how to introduce an automated test for this given that it's a performance issue and this code isn't very testable in isolation. I've tried designing a benchmark to measure preemption performance a few times unsuccessfully.