-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Feat: Add C #368
base: main
Are you sure you want to change the base?
[WIP] Feat: Add C #368
Conversation
Just to confirm, are you running the edit_grammars script from this document after making changes? You need to do that before running cargo test. Your failing test is likely reflective of grammars not being updated. |
Thanks, this must be the issue. I wasn’t running that script. |
Please do read the documentation / contributing guide thoroughly. It covers important details. |
@jmqd Just checking - need any further advice on this? |
This file is so big that github.com is hanging up on my git pushes.
Hey @morgante, I was able to spend another hour and change on this. I pushed those working changes. I got the I have a few tests passing, but after a variety of iterations/combinations in the grammar file, I can't get gritql to match the
I'm relatively low confidence on how I did the conflict resolution, as it's my first time touching one of these JS grammar files. I tried various combinations of LMK if you see anything obviously wrong in the grammar file specifically, unless there's some plumbing that I've missed. One of the weird parts about
Thanks, appreciate the note here. I've also made note of a few places where it is insufficient so I can add to those docs. For example, making mention of the |
I had a few hours to take a swing at this. This is a time-boxed PR and still WIP.
Open questions:
I still don't grok the patching the grammar business, e.g. when to use
field
vs barechoice
, and also I'm not yet confident that when I changecpp-metavariable-grammar.js
the changes are immediately reflected incargo test
, so I need to verify that my edit-test loop is correct (e.g. no cached artifacts or anything.)I wanted to add the following test, but it was failing. I assume it's because of (1) above. I assume grokking this one case will enable me to add and fix many similar grammar-related cases.
The failure symptom: