Any way this could be looked at and potentially merged ?
Thank you.

👍 on this PR. We currently have this monkey-patched in our codebase. Can this be merged and a new version be released?

Friendly ping @mnoack @dsantosmerino :)

Looks good to me, lets get this merged and closed.

I don't have time to review adding another dependency, the resolv Gem, so I can't approve this PR.

If someone wants to write a class that brings those regex checks into the Gem directly, that's a better idea. We also don't need to support many of the ipv6 things supported in Resolv - for example, local addresses and interface addresses will not be useful for geocoding purposes.

Please also include tests checking that determining if a query is an IP works as expected.

Just in cas you missed it, Resolv is not an external gem but part of the ruby stdlib so do you still thing it is worth rewritting it in geokit ?
If I understand your comment about testing, the test is already included for the ipv4 just above the added test for ipv6 or did I miss the point of your comment ?

Ah, I see you're right, then it's probably fine.

I'd like to see a few tests that verify that that ipv6 addresses are correctly parsed, like

def test_valid_ipv6_addresses

def test_invalid_ipv6_addresses

I've been trying to get this crate to have all tests passing, but I think there are some non-VCR'd calls that are varying from my local versus the crate version.