Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup KAccounts situation phonon backend IUSE change #997

Merged
merged 7 commits into from
Jul 1, 2024

Conversation

a17r
Copy link
Member

@a17r a17r commented Jun 30, 2024

Summary:

kde-apps/kaccounts-providers: Drop IUSE webengine, add qml USEdep

Let's not kid ourselves: net-libs/signon-ui will pull in dev-qt/qtwebengine
anyway.

kde-apps/kaccounts-integration: Add PDEPEND=kde-apps/kaccounts-providers

kde-apps/kaccounts-integration provides kcm_accounts for systemsettings,
however without kde-apps/kaccounts-providers the list is practically empty
which makes no sense.

So far, only kde-apps/kdenetwork-meta and kde-misc/kio-gdrive had been
pulling it in but we cannot assume every Plasma user would have those
installed.

kde-apps/kaccounts-integration: RDEPEND on signon-kwallet-extension:6

This package already depends on kde-frameworks/kwallet so in this case
we do not introduce a perceived extra dependency. It is also where Arch
Linux chose to put it.

Closes: https://bugs.gentoo.org/642420

Various packages: Rename IUSE kaccounts -> webengine

kde-apps/kaccounts-integration inevitably pulls in -providers which
pulls in dev-qt/qtwebengine.

media-libs/phonon: Switch IUSE vlc to minimal

With only a single available backend left, it does not make that much sense
to rely on a commonly disabled flag to provide major functionality, even if
enabled by default.

Bug: https://bugs.gentoo.org/935033

@a17r a17r requested a review from thesamesam June 30, 2024 10:30
@a17r

This comment was marked as resolved.

@a17r a17r changed the title Cleanup KAccounts situation Cleanup KAccounts situation phonon backend IUSE change Jul 1, 2024
@a17r a17r force-pushed the kaccounts-vs-webengine branch 2 times, most recently from 8471059 to 048b2a0 Compare July 1, 2024 16:42
a17r added 7 commits July 1, 2024 20:42
Let's not kid ourselves: net-libs/signon-ui will pull in dev-qt/qtwebengine
anyway.

Signed-off-by: Andreas Sturmlechner <[email protected]>
kde-apps/kaccounts-integration provides kcm_accounts for systemsettings,
however without kde-apps/kaccounts-providers the list is practically empty
which makes no sense.

So far, only kde-apps/kdenetwork-meta and kde-misc/kio-gdrive had been
pulling it in but we cannot assume every Plasma user would have those
installed.

Signed-off-by: Andreas Sturmlechner <[email protected]>
This package already depends on kde-frameworks/kwallet so in this case
we do not introduce a perceived extra dependency. It is also where Arch
Linux chose to put it.

Closes: https://bugs.gentoo.org/642420
Signed-off-by: Andreas Sturmlechner <[email protected]>
kde-apps/kaccounts-integration inevitably pulls in -providers which
pulls in dev-qt/qtwebengine.

Signed-off-by: Andreas Sturmlechner <[email protected]>
kde-apps/kaccounts-integration inevitably pulls in -providers which
pulls in dev-qt/qtwebengine.

Signed-off-by: Andreas Sturmlechner <[email protected]>
kde-apps/kaccounts-integration inevitably pulls in -providers which
pulls in dev-qt/qtwebengine.

Signed-off-by: Andreas Sturmlechner <[email protected]>
With only a single available backend left, it does not make that much sense
to rely on a commonly disabled flag to provide major functionality, even if
enabled by default.

Bug: https://bugs.gentoo.org/935033
Signed-off-by: Andreas Sturmlechner <[email protected]>
@gentoo-bot gentoo-bot merged commit aa4456b into gentoo:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants