Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify logging when removing Route53 records #104

Open
e1ven opened this issue Apr 12, 2021 · 0 comments
Open

Clarify logging when removing Route53 records #104

e1ven opened this issue Apr 12, 2021 · 0 comments

Comments

@e1ven
Copy link

e1ven commented Apr 12, 2021

When leftovers detects a matching A record inside of a non-matching Route53 zone, the log is potentially ambiguous about what will be removed.

For example, if we create a zone example-shared-zone.com.
Within that zone, we create an A record of single-record.example-shared-zone.com. 300 IN A 1.2.3.4

Leftovers will display the message:

$ leftovers --iaas=aws --filter single-record
[Route53 Hosted Zone: example-shared-zone.com.] Delete? (y/N): y
[Route53 Hosted Zone: example-shared-zone.com.] Deleting...
[Route53 Hosted Zone: example-shared-zone.com.] Deleted!
$ 

Similar behavior is demonstrated when running in --dry-run mode:

$ leftovers --dry-run --iaas=aws  --filter single-record
[Route53 Hosted Zone: example-shared-zone.com.]
$ 

The output could be interpreted as saying it will delete the whole zone, but from testing it will only delete the record (as desired/expected).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants