Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter annotations by evidence is not working #716

Closed
vanaukenk opened this issue Apr 9, 2024 · 16 comments
Closed

Filter annotations by evidence is not working #716

vanaukenk opened this issue Apr 9, 2024 · 16 comments

Comments

@vanaukenk
Copy link

When viewing a list of annotations in AmiGO, it is no longer possible to filter by Evidence.

Clicking on the Evidence facet says 'Nothing to filter'.

image

This may also be related to an issue with the Noctua Search Annotations functionality reported today by @pmasson55

geneontology/noctua-visual-pathway-editor#75

@pgaudet
Copy link

pgaudet commented Apr 9, 2024

Thanks for reporting this Kimberly. I also got that problem; it was in amigo.staging - did something happen in the last release/snapshot?

@kltm
Copy link
Member

kltm commented Apr 9, 2024

After the last GO release, evidence filters are no longer working in AmiGO.

To reproduce:

The evidence filter should contain a fair number of entries.

@kltm
Copy link
Member

kltm commented Apr 9, 2024

Seems specific to "Evidence" only. Hm.

@kltm
Copy link
Member

kltm commented Apr 9, 2024

Noting that the loaded ontology would have been ontology/extensions/go-amigo.owl

There have been no changes to the loading software since the last release, so I think it's safe to put that to the side.

The likely fruitful paths are:

  • there was something that happened in the pipeline changes (which seems unlikely as everything seems to have been fine except evidence)
  • there was a change in ECO that had some effect
  • there was a change in the ontology build or build of go-amigo.owl that had some effect

I'm still digging around on the first on that list, but so far nothing.
We likely need to slide into damage control for the moment: leave as-is or revert to last AmiGO index (and add warning note).

@balhoff
Copy link
Member

balhoff commented Apr 9, 2024

@kltm related to this? geneontology/noctua#860

@kltm
Copy link
Member

kltm commented Apr 9, 2024

@balhoff Yes, could be, but it looks like we have not dug down very far in that ticket.
Talking to @pgaudet , she is leery about jumping back to the previous (~2m/o) index to "fix" things as a temporary measure. If we want to go with the ECO-not-getting-through theory, we would either need to dig in there or go back to loading files separately (at least in the short term).

@kltm
Copy link
Member

kltm commented Apr 9, 2024

With @balhoff 's PR in, I'd proposed we start a rebuild and check on staging.

@kltm
Copy link
Member

kltm commented Apr 9, 2024

snapshot attempt underway. If things go well, we could maybe have product to look at later tomorrow.

@kltm
Copy link
Member

kltm commented Apr 9, 2024

Noting report from @raymond91125 about the knock-on effects to go-annotation reports.

@kltm
Copy link
Member

kltm commented Apr 10, 2024

We have tested @balhoff 's fix, which seems good for the "Evidence" filter, but are waiting on shifting to a release due to other issues.

@suzialeksander
Copy link

@kltm (or @dustine32 might know) do we have an ETA for a fix? Does this need to wait for next week's outage or is there a chance it will be fixed before that?

@kltm
Copy link
Member

kltm commented Apr 18, 2024

@suzialeksander This independent on any outage--it is tied to a new release.
We have discussed how to proceed with some "problematic sources" that occurred since last release (see geneontology/pipeline#373) and have just started a run that could potentially fix everything. The soonest possible deployment would be Friday or into the weekend, but that would depend on other sources, etc., being as we expect.

@kltm
Copy link
Member

kltm commented Apr 20, 2024

Now in production.

@kltm kltm closed this as completed Apr 20, 2024
@kltm
Copy link
Member

kltm commented Apr 20, 2024

@vanaukenk When you have time, can you check the expression of this in Noctua?

@pgaudet
Copy link

pgaudet commented Apr 22, 2024

Noctua's "Search annotation" functionality works for me.

@vanaukenk
Copy link
Author

Yes, this looks to be working again in Noctua.

Thanks @balhoff @kltm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants