This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Executejs arguments #780
Open
Executejs arguments #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sipayRT
reviewed
Jun 23, 2017
| @@ -392,7 392,7 @@ function replaceStack(error, stack) { | |||
| } | |||
|
|
|||
| function serializeFunc(func) { | |||
| return '(' func.toString() '(window));'; | |||
| return '(' func.toString() ').apply(null, [window].concat(Array.prototype.slice.call(arguments)));'; | |||
There was a problem hiding this comment.
why do you use null instead of window?
There was a problem hiding this comment.
No particular reason. null should get replaced with the global object, which in the browser is window, so I believe they're equivalent. I can change it to window.
|
Will this be merged anytime soon? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to be able to pass arguments into executeJS. It seems this functionality would be useful to others based on #429. I found this approach in #284, which appears to have been rejected because of the other changes it included.
I searched the tests for executeJS and serializeFunc, but was unable to find an obvious place to add new tests for this feature. If this looks ok, please let me know where I should add tests.