Fix build and update to syn v2 #518
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-string literals `c""` https://doc.rust-lang.org/edition-guide/rust-2021/c-string-literals.html : thread '<unnamed>' panicked at /Users/user/.cargo/registry/src/index.crates.io-6f17d22bba15001f/syn-1.0.109/src/lit.rs:1020:13: Unrecognized literal: `c""`
…parse file: /Users/user/.cargo/git/checkouts/itertools-eb89fd56766bcf43/8761fbe/src/format.rs, Syn(Error("expected ','").
|
This PR keeps growing and growing as I fix more tests. I would love to hear suggestions for splitting it up. It would also be great if there was a way to get |
|
We're re-writing much of the core incl. to break the cargo-reliance so messy PR is ok for now to fix the techdebt np. Thanks so much for doing this 🚀 |
pinkforest
reviewed
Apr 19, 2024
| @@ -0,0 1 @@ | |||
| 1.76 | |||
There was a problem hiding this comment.
Pinning causes other problems. We can use rust-version in Cargo.toml for MSRV if we are to bump it.
EDIT: I misread your comment - yeah we need to address the core problem really. Thanks for identifying it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #517 . Here's what it does
integration_tests__test9_package_with_git_deps.stdout.snapto match a package version in Cargo.locksynv1 to v2 to support new C-style string literals. This fixes the panic:Unrecognized literal: c"".cargo_metadatacrate to v0.18. This will require major changes to cargo-geiger's code.Problems in this PR: