-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce install friction for macOS users #149
Comments
I'm one of those users that don't use Homebrew as well :)
This information is available at the top of the readme file, did you find this information somewhere else?
Yes, getting the OpenSSL error message is a garbage user experience.
I like this direction, but that means fully decoupling from
If we can make this explicit only for macOS users that would be fine with me. Let's not make the experience worse for everyone else.
No, this cargo feature name should mirror the same feature name in the upstream library https://github.com/rust-lang/cargo/blob/12c107ade5a3b173cdac5d06c8ba92429fe93c74/Cargo.toml#L120, this will make it easier to search for both in source code and on google.
A PR with README.md improvements would be most welcome.
This suggestion was discussed in #99 and we opted for the explicit cargo feature instead.
This would be a nice improvement for the user experience on macOS! If you would like to make a PR for this, that would be great! Make sure to preserve the current install behaviour for other platforms, |
1 to this. We use the same feature name for |
The build fails on macOS 10.15.7:
Many macOS users do not install Homebrew. "As a maintainer" sounds like I would need to download the source code and modify
Cargo.toml
to specify the different dependency. This is a extra work.It turns out that on macOS, one can simply add
--feature vendored-openssl
to build successfully. I saw that, but didn't know what "vendored" meant. I assumed it was a special third-party SSL library that one would buy from a vendor.I think this experience could be improved a lot by preventing the build error. And if it can't be prevented, then prevent confusion. Ideas for doing this:
local-openssl
feature.vendored-openssl
to a term that is understood by more engineers. Suggestion:openssl-crate
vendored-openssl
feature uses "OpenSSL from the openssl-sys crate" and builds on macOS.cargo install cargo-geiger --features vendored-openssl
to build with OpenSSL from the openssl-sys crate."I will prepare a PR, if you wish. Please let me know if you want to address this issue and what you prefer.
The text was updated successfully, but these errors were encountered: