Bug fix - another instance of a filter widget that needs closed

If the user has a custom column, then uses the drop down to change that to something else, I need to close the previous filter widget to avoid leaking goroutines.
gcla · Feb 22, 2021 · 4dcdd54 · 4dcdd54
1 parent be060d6
commit 4dcdd54
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/ui/psmlcolsmodel.go b/ui/psmlcolsmodel.go
@@ -272,6  272,14 @@ func (p *psmlColumnsModel) ReadFromWireshark(app gowid.IApp) error {
 
 // Called when user chooses from a menu - so will only have PsmlField Token name
 func (p *psmlColumnsModel) UpdateFromField(field string, idx int, app gowid.IApp) {
 
 	if p.spec[idx].Field.Token == "%Cus" && field != "%Cus" {
 		err := m.widgets[idx].customFilter.Close()
 		if err != nil {
 			log.Warnf("Unexpected response when closing filter: %v", err)
 		}
 	}
 
 	p.spec[idx].Field.Token = field
 	p.spec[idx].Name = shark.AllowedColumnFormats[field].Long