Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ign ➡️ gz] Logo, docs, tools #1517

Merged
merged 4 commits into from
Jun 6, 2022
Merged

[ign ➡️ gz] Logo, docs, tools #1517

merged 4 commits into from
Jun 6, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jun 3, 2022 •
edited
Loading

Summary

  • Logo on Ubuntu
  • Docker
  • Remaining docs (including API, tutorials, examples, tests)

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 3, 2022
@chapulina chapulina requested a review from methylDragon June 3, 2022 22:34
@chapulina chapulina added the 🌱 garden Ignition Garden label Jun 3, 2022
@chapulina chapulina mentioned this pull request Jun 3, 2022
Merged
@chapulina
tweaks
33dd189 
Signed-off-by: Louise Poubel <[email protected]>
@codecov
Copy link

codecov bot commented Jun 3, 2022 •
edited
Loading

Codecov Report

Merging #1517 (f525702) into main (2e141c2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1517    /-   ##
=======================================
  Coverage   63.62%   63.62%           
=======================================
  Files         330      330           
  Lines       25784    25784           
=======================================
  Hits        16405    16405           
  Misses       9379     9379
Impacted Files Coverage Δ
include/gz/sim/Util.hh 100.00% <ø> (ø)
include/gz/sim/gui/GuiSystem.hh 0.00% <ø> (ø)
include/gz/sim/rendering/SceneManager.hh 100.00% <ø> (ø)
src/Server.cc 89.72% <ø> (ø)
src/Util.cc 92.53% <ø> (ø)
src/gui/plugins/modules/EntityContextMenu.cc 19.78% <ø> (ø)
src/gui/plugins/spawn/Spawn.cc 10.27% <ø> (ø)
.../gui/plugins/transform_control/TransformControl.cc 7.37% <ø> (ø)
...lization_capabilities/VisualizationCapabilities.cc 3.69% <ø> (ø)
src/rendering/MarkerManager.cc 13.02% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e141c2...f525702. Read the comment docs.

methylDragon
methylDragon approved these changes Jun 4, 2022
View reviewed changes
Copy link
Contributor

@methylDragon methylDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we'll need to rebase since files have moved

chapulina added 2 commits June 6, 2022 10:43
@chapulina
merged from main
2483142 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
rm
f525702 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit 20a7779 into main Jun 6, 2022
@chapulina chapulina deleted the chapulina/7/gz_UI branch June 6, 2022 23:51
@chapulina chapulina mentioned this pull request Jun 6, 2022
Closed
16 tasks
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methylDragon methylDragon methylDragon approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @methylDragon