Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle null mesh pointers in examples #982

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Handle null mesh pointers in examples #982

merged 1 commit into from
Mar 22, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 22, 2024

🦟 Bug fix

Summary

Add some sanity checks and for null pointers returned by common::MeshManager::Load().

Also removed a few MeshManager headers that are not used.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033
check null mesh
9658394 
Signed-off-by: Ian Chen <[email protected]>
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Mar 22, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.68%. Comparing base (9f97f42) to head (9658394).

Additional details and impacted files 
@@                Coverage Diff                @@
##           gz-rendering8     #982       /-   ##
=================================================
- Coverage          75.68%   75.68%   -0.01%     
=================================================
  Files                177      177              
  Lines              16959    16959              
=================================================
- Hits               12836    12835       -1     
- Misses              4123     4124        1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit e187f52 into gz-rendering8 Mar 22, 2024
10 of 13 checks passed
@iche033 iche033 deleted the null_mesh branch March 22, 2024 23:52
@iche033 iche033 mentioned this pull request Mar 23, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll mjcarroll approved these changes

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iche033 @mjcarroll