Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parcel flag #39050

Closed
wants to merge 33 commits into from
Closed

Add parcel flag #39050

wants to merge 33 commits into from

Conversation

emmron
Copy link

@emmron emmron commented Jul 26, 2024

Description

Documentation

Tests

Related Issues

emmron added 30 commits July 13, 2024 02:42
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix and pathPrefix are correctly a…
59a6a14 
…pplied to URLs in manifest.webmanifest and HTML head.
@emmron
Fix code formatting issues with prettier
cdf9751
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix and pathPrefix are correctly a…
cf9c0dd 
…pplied to URLs in manifest.webmanifest and HTML head.
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
ed4da64 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Fix gatsbyjs#25207: Apply assetPrefix and pathPrefix to URLs in manif…
0b4e85b 
…est.webmanifest and HTML head. Ensured correct path handling and resolved linting issues by updating string literals and formatting.
@emmron
Fix gatsbyjs#25207: Apply assetPrefix and pathPrefix to URLs in manif…
d2145b7 
…est.webmanifest and HTML head. Ensured correct path handling and resolved linting issues by updating string literals and formatting.
@emmron
Fix gatsbyjs#25207: Apply assetPrefix and pathPrefix to URLs in manif…
e741725 
…est.webmanifest and HTML head. Ensured correct path handling and resolved linting issues by updating string literals and formatting.
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
ba33b0f 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
aa33153 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
57146ab 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
ecc6a14 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
ba076e5 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
09eac27 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
06ad76f 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
872ba6c 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
1a82468 
…tPrefix and pathPrefix
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
c9bae75 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
4db96d8 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
39bfc7e 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
92912c0 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
1276ee9 
…tPrefix and pathPrefix
@emmron
Fix: Ensure icons in manifest.webmanifest are prefixed with both asse…
e41eee8 
…tPrefix and pathPrefix
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
bf624b0 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
638c03e 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
1eda1ef 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
5dc2d70 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
i am a retard
426ee73
@emmron
Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …
3198751 
…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.
@emmron
Create devcontainer.json
8c8243f
@emmron
Merge pull request #1 from emmron/master
e59ea7f 
Create devcontainer.json
@emmron
Merge pull request #2 from emmron/fix-issue-25207
653aa48 
Fix issue 25207
@emmron
Add DISABLE_PARCEL_FOR_CONFIG flag and related changes
fd2b4ce 
- Add DISABLE_PARCEL_FOR_CONFIG flag to gatsby-config.js
- Add 'develop' script with Parcel flag to package.json
- Implement DISABLE_PARCEL_FOR_CONFIG flag in flags.ts with comprehensive checks
- Refactor and improve existing code in flags.ts
- Update .eslintrc.js to remove TypeScript linting rules
- Update .circleci/config.yml to remove unnecessary cache management
- Add .cursorignore and devcontainer.json files
- Add npm scripts for linting and formatting
- Add npm as a dependency
- Update manifest creation function in gatsby-node.js
- Add yarnrun file
@emmron
Add DISABLE_PARCEL_FOR_CONFIG flag and related changes
c18ed09 
   - Add DISABLE_PARCEL_FOR_CONFIG flag to gatsby-config.js
   - Add 'develop' script with Parcel flag to package.json
   - Implement DISABLE_PARCEL_FOR_CONFIG flag in flags.ts with comprehensive checks
   - Refactor and improve existing code in flags.ts
   - Update .eslintrc.js to remove TypeScript linting rules
   - Update .circleci/config.yml to remove unnecessary cache management
   - Add .cursorignore and devcontainer.json files
   - Add npm scripts for linting and formatting
   - Add npm as a dependency
   - Update manifest creation function in gatsby-node.js
   - Add yarnrun file
@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Jul 26, 2024
@serhalp serhalp mentioned this pull request Oct 29, 2024
Closed
@serhalp
Copy link
Contributor

serhalp commented Oct 29, 2024

@emmron This PR is very large and unwieldy, updates unrelated code, and it isn't clear to me what it's solving. To be honest it looks like it may even have been AI generated, and it looks very similar to #39042. I'm going to close it, but please feel free to open smaller, more easily reviewable PRs.

@serhalp serhalp closed this Oct 29, 2024
emmron
emmron commented Nov 3, 2024
View reviewed changes
Copy link
Author

@emmron emmron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhalp

@emmron
Copy link
Author

emmron commented Nov 3, 2024

@serhalp
This pull request includes several updates across multiple files to clean up code, add new features, and improve overall functionality. The most important changes include removing commented-out code in the ESLint configuration, adding a new development container configuration, and refactoring the gatsby-node.js file for better error handling and code readability.

Code Cleanup and Configuration:

New Features:

  • .devcontainer/devcontainer.json: Added a new development container configuration using Microsoft's universal image.
  • package.json: Added a new develop script to enable experimental Parcel support for Gatsby development.

Refactoring and Improvements:

Minor Changes:

emmron
emmron commented Nov 3, 2024
View reviewed changes
Copy link
Author

@emmron emmron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ @

emmron
emmron commented Nov 3, 2024
View reviewed changes
Copy link
Author

@emmron emmron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serhalp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmron @serhalp