Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin joi version in peril #27235

Merged
merged 1 commit into from
Oct 2, 2020
Merged

chore: pin joi version in peril #27235

merged 1 commit into from
Oct 2, 2020

Conversation

wardpeet
Copy link
Contributor

@wardpeet wardpeet commented Oct 2, 2020

Description

Try pinning joi version

heroku log 
2020-10-02T09:40:35.574507 00:00 app[web.1]: info: status.failure on unknown skipped
2020-10-02T09:40:36.145531 00:00 app[web.1]: Unable to evaluate the Dangerfile
2020-10-02T09:40:36.145540 00:00 app[web.1]:  { ValidationError: {
2020-10-02T09:40:36.145541 00:00 app[web.1]:   "base": {
2020-10-02T09:40:36.145541 00:00 app[web.1]:     "type": "string",
2020-10-02T09:40:36.145541 00:00 app[web.1]:     "$_root": {
2020-10-02T09:40:36.145541 00:00 app[web.1]:       "_types": [
2020-10-02T09:40:36.145542 00:00 app[web.1]:         "alternatives",
2020-10-02T09:40:36.145542 00:00 app[web.1]:         "any",
2020-10-02T09:40:36.145542 00:00 app[web.1]:         "array",
2020-10-02T09:40:36.145542 00:00 app[web.1]:         "boolean",
2020-10-02T09:40:36.145543 00:00 app[web.1]:         "date",
2020-10-02T09:40:36.145543 00:00 app[web.1]:         "function",
2020-10-02T09:40:36.145543 00:00 app[web.1]:         "link",
2020-10-02T09:40:36.145543 00:00 app[web.1]:         "number",
2020-10-02T09:40:36.145559 00:00 app[web.1]:         "object",
2020-10-02T09:40:36.145560 00:00 app[web.1]:         "string",
2020-10-02T09:40:36.145560 00:00 app[web.1]:         "symbol",
2020-10-02T09:40:36.145560 00:00 app[web.1]:         "binary"
2020-10-02T09:40:36.145560 00:00 app[web.1]:       ],
2020-10-02T09:40:36.145561 00:00 app[web.1]:       "alternatives": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145561 00:00 app[web.1]:       "any": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145562 00:00 app[web.1]:       "array": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145562 00:00 app[web.1]:       "boolean": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145562 00:00 app[web.1]:       "date": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145562 00:00 app[web.1]:       "function": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145563 00:00 app[web.1]:       "link": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145563 00:00 app[web.1]:       "number": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145563 00:00 app[web.1]:       "object": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145563 00:00 app[web.1]:       "string": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145564 00:00 app[web.1]:       "symbol": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145569 00:00 app[web.1]:       "binary": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145570 00:00 app[web.1]:       "allow": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145570 00:00 app[web.1]:       "custom": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145570 00:00 app[web.1]:       "disallow": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145571 00:00 app[web.1]:       "equal": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145571 00:00 app[web.1]:       "exist": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145571 00:00 app[web.1]:       "forbidden": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145576 00:00 app[web.1]:       "invalid": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145576 00:00 app[web.1]:       "not": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145576 00:00 app[web.1]:       "only": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145577 00:00 app[web.1]:       "optional": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145577 00:00 app[web.1]:       "options": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145577 00:00 app[web.1]:       "prefs": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145577 00:00 app[web.1]:       "preferences": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145578 00:00 app[web.1]:       "required": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145578 00:00 app[web.1]:       "strip": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145578 00:00 app[web.1]:       "valid": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145578 00:00 app[web.1]:       "when": function (...args) {\n\n            return this.any()[method](...args);\n        },
2020-10-02T09:40:36.145579 00:00 app[web.1]:       "ValidationError": "[class extends Error {\n\n    constructor(message, details, original) {\n\n        super(message);\n        this._original = original;\n        this.details = details;\n    }\n\n    static isError(err) {\n\n        return err instanceof exports.ValidationError;\n    }\n}]",
2020-10-02T09:40:36.145579 00:00 app[web.1]:       "version": "17.2.1",
2020-10-02T09:40:36.145579 00:00 app[web.1]:       "cache": {
2020-10-02T09:40:36.145580 00:00 app[web.1]:         "provision": "[provision(options) {\n\n        return new internals.Cache(options);\n    }]"
2020-10-02T09:40:36.145580 00:00 app[web.1]:       },
2020-10-02T09:40:36.145580 00:00 app[web.1]:       "assert": "[assert(value, schema, ...args /* [message], [options] */) {\n\n        internals.assert(value, schema, true, args);\n    }]",
2020-10-02T09:40:36.145588 00:00 app[web.1]:       "attempt": "[attempt(value, schema, ...args /* [message], [options] */) {\n\n        return internals.assert(value, schema, false, args);\n    }]",
2020-10-02T09:40:36.145588 00:00 app[web.1]:       "build": "[build(desc) {\n\n        Assert(typeof Manifest.build === 'function', 'Manifest functionality disabled');\n        return Manifest.build(this, desc);\n    }]",
2020-10-02T09:40:36.145588 00:00 app[web.1]:       "checkPreferences": "[checkPreferences(prefs) {\n\n        Common.checkPreferences(prefs);\n    }]",
2020-10-02T09:40:36.145589 00:00 app[web.1]:       "compile": "[compile(schema, options) {\n\n        return Compile.compile(this, schema, options);\n    }]",
2020-10-02T09:40:36.145590 00:00 app[web.1]:       "defaults": "[defaults(modifier) {\n\n        Assert(typeof modifier === 'function', 'modifier must be a function');\n\n        const joi = Object.assign({}, this);\n        for (const type of joi._types) {\n            const schema = modifier(joi[type]());\n            Assert(Common.isSchema(schema), 'modifier must return a valid schema object');\n\n            joi[type] = function (...args) {\n\n                return internals.generate(this, schema, args);\n            };\n        }\n\n        return joi;\n    }]",
2020-10-02T09:40:36.145590 00:00 app[web.1]:       "expression": "[expression(...args) {\n\n        return new Template(...args);\n    }]",
2020-10-02T09:40:36.145596 00:00 app[web.1]:       "extend": "[extend(...extensions) {\n\n        Common.verifyFlat(extensions, 'extend');\n\n        Schemas = Schemas || require('./schemas');\n\n        Assert(extensions.length, 'You need to provide at least one extension');\n        this.assert(extensions, Schemas.extensions);\n\n        const joi = Object.assign({}, this);\n        joi._types = new Set(joi._types);\n\n        for (let extension of extensions) {\n            if (typeof extension === 'function') {\n                extension = extension(joi);\n            }\n\n            this.assert(extension, Schemas.extension);\n\n            const expanded = internals.expandExtension(extension, joi);\n            for (const item of expanded) {\n                Assert(joi[item.type] === undefined || joi._types.has(item.type), 'Cannot override name', item.type);\n\n                const base = item.base || this.any();\n                const schema = Extend.type(base, item);\n\n                joi._types.add(item.type);\n                joi[item.type] = function (...args) {\n\n                    return internals.generate(this, schema, args);\n                };\n            }\n        }\n\n        return joi;\n    }]",
2020-10-02T09:40:36.145598 00:00 app[web.1]:       "isError": "[isError(err) {\n\n        return err instanceof exports.ValidationError;\n    }]",
2020-10-02T09:40:36.145599 00:00 app[web.1]:       "isExpression": "[isTemplate(template) {\n\n        return template ? !!template[Common.symbols.template] : false;\n    }]",
2020-10-02T09:40:36.145599 00:00 app[web.1]:       "isRef": function (ref) {\n\n    return ref ? !!ref[Common.symbols.ref] : false;\n},
2020-10-02T09:40:36.145599 00:00 app[web.1]:       "isSchema": function (schema, options = {}) {\n\n    const any = schema && schema[exports.symbols.any];\n    if (!any) {\n        return false;\n    }\n\n    Assert(options.legacy || any.version === exports.version, 'Cannot mix different versions of joi schemas');\n    return true;\n},
2020-10-02T09:40:36.145600 00:00 app[web.1]:       "in": "[in(...args) {\n\n        return Ref.in(...args);\n    }]",
2020-10-02T09:40:36.145600 00:00 app[web.1]:       "override": Symbol(override),
2020-10-02T09:40:36.145600 00:00 app[web.1]:       "ref": "[ref(...args) {\n\n        return Ref.create(...args);\n    }]",
2020-10-02T09:40:36.145601 00:00 app[web.1]:       "types": "[types() {\n\n        const types = {};\n        for (const type of this._types) {\n            types[type] = this[type]();\n        }\n\n        for (const target in internals.aliases) {\n            types[target] = this[target]();\n        }\n\n        return types;\n    }]",
2020-10-02T09:40:36.145601 00:00 app[web.1]:       "alt": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145601 00:00 app[web.1]:       "bool": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145602 00:00 app[web.1]:       "func": function (...args) {\n\n            Assert(!args.length || ['alternatives', 'link', 'object'].includes(type), 'The', type, 'type does not allow arguments');\n            return internals.generate(this, internals.types[type], args);\n        },
2020-10-02T09:40:36.145602 00:00 app[web.1]:       "x": "[expression(...args) {\n\n        return new Template(...args);\n    }]",
2020-10-02T09:40:36.145602 00:00 app[web.1]:       "trace": function () {\n\n        root._tracer = root._tracer || new internals.Tracer();\n        return root._tracer;\n    },
2020-10-02T09:40:36.145603 00:00 app[web.1]:       "untrace": () => {\n\n        root._tracer = null;\n    }
2020-10-02T09:40:36.145603 00:00 app[web.1]:     },
2020-10-02T09:40:36.145603 00:00 app[web.1]:     "$_temp": {
2020-10-02T09:40:36.145603 00:00 app[web.1]:       "ruleset": null,
2020-10-02T09:40:36.145603 00:00 app[web.1]:       "whens": {}
2020-10-02T09:40:36.145604 00:00 app[web.1]:     },
2020-10-02T09:40:36.145604 00:00 app[web.1]:     "_ids": {
2020-10-02T09:40:36.145604 00:00 app[web.1]:       "_byId": [],
2020-10-02T09:40:36.145604 00:00 app[web.1]:       "_byKey": [],
2020-10-02T09:40:36.145604 00:00 app[web.1]:       "_schemaChain": false
2020-10-02T09:40:36.145604 00:00 app[web.1]:     },
2020-10-02T09:40:36.145605 00:00 app[web.1]:     "_preferences": null,
2020-10-02T09:40:36.145605 00:00 app[web.1]:     "_valids": null,
2020-10-02T09:40:36.145605 00:00 app[web.1]:     "_invalids": null,
2020-10-02T09:40:36.145605 00:00 app[web.1]:     "_rules": [],
2020-10-02T09:40:36.145605 00:00 app[web.1]:     "_singleRules": [],
2020-10-02T09:40:36.145606 00:00 app[web.1]:     "_refs": {
2020-10-02T09:40:36.145606 00:00 app[web.1]:       "refs": []
2020-10-02T09:40:36.145606 00:00 app[web.1]:     },
2020-10-02T09:40:36.145606 00:00 app[web.1]:     "_flags": {},
2020-10-02T09:40:36.145606 00:00 app[web.1]:     "_cache": null,
2020-10-02T09:40:36.145607 00:00 app[web.1]:     "$_terms": {
2020-10-02T09:40:36.145607 00:00 app[web.1]:       "alterations": null,
2020-10-02T09:40:36.145607 00:00 app[web.1]:       "examples": null,
2020-10-02T09:40:36.145607 00:00 app[web.1]:       "externals": null,
2020-10-02T09:40:36.145607 00:00 app[web.1]:       "metas": [],
2020-10-02T09:40:36.145608 00:00 app[web.1]:       "notes": [],
2020-10-02T09:40:36.145608 00:00 app[web.1]:       "shared": null,
2020-10-02T09:40:36.145608 00:00 app[web.1]:       "tags": [],
2020-10-02T09:40:36.145608 00:00 app[web.1]:       "whens": null,
2020-10-02T09:40:36.145608 00:00 app[web.1]:       "replacements": null
2020-10-02T09:40:36.145608 00:00 app[web.1]:     },
2020-10-02T09:40:36.145608 00:00 app[web.1]:     "$_super": {}
2020-10-02T09:40:36.145609 00:00 app[web.1]:   },

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Oct 2, 2020
pieh
pieh approved these changes Oct 2, 2020
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pieh pieh added bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Oct 2, 2020
@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 2, 2020

Gatsby Cloud Build Report

gatsby

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 20m

@pieh pieh removed the topic: automation Related to Circle CI, Peril, Renovate, scripts/*, Github Workflows, Github Actions, or Slackbot label Oct 2, 2020
@wardpeet wardpeet merged commit 4f7622e into master Oct 2, 2020
@delete-merged-branch delete-merged-branch bot deleted the chore/peril-joi-version branch October 2, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wardpeet @pieh