Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(starter-showcase): added description field to mccrodp's starter repo #10858

Merged
merged 2 commits into from
Jan 10, 2019

Conversation

mccrodp
Copy link
Contributor

@mccrodp mccrodp commented Jan 6, 2019

Description

Just a simple description field update on my starter repo added previously.

Related Issues

Originally added for Gatsby v1 here: #4138, but I just upgraded to v2 and checked the starters.md. Thanks for adding that! 🙇

@mccrodp mccrodp requested a review from a team January 6, 2019 00:27
@mccrodp
Copy link
Contributor Author

mccrodp commented Jan 6, 2019

Actually, it seems you pull in the desc from the repo, that's better, this can be closed, but might be good to add that as a comment the starters.md code snippet in the docs? https://www.gatsbyjs.org/docs/submit-to-starter-library/#steps

@pieh
Copy link
Contributor

pieh commented Jan 7, 2019

I didn't even know we read package.json description, but it does seems a bit inconsistent:

Might be worth to look into consolidating those? Not sure if it was intentional or not.

/cc @amberleyromo

@mccrodp
Copy link
Contributor Author

mccrodp commented Jan 10, 2019

Nice find, @pieh. It also seems that the description pulled and displayed for my starter is not the current one. I updated it 4 days ago, so not sure how those are cached either.

@pieh
Copy link
Contributor

pieh commented Jan 10, 2019

I'm not sure either about caching here - I lack lot of context on how starter showcase works, but let's merge PR in meantime, so your starter have proper description ;)

@pieh pieh changed the title Added description field to mccrodp's starter repo fix(starter-showcase): added description field to mccrodp's starter repo Jan 10, 2019
@pieh pieh merged commit d7f8e77 into gatsbyjs:master Jan 10, 2019
@gatsbot
Copy link

gatsbot bot commented Jan 10, 2019

Holy buckets, @mccrodp — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@mccrodp mccrodp deleted the docs/gatsby-starter-contentful-i18n branch January 12, 2019 12:36
gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants