Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Switch from structs to clos #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kilianmh
Copy link
Sponsor

  • convert structs to classes: uri, urn, uri-ftp, uri-file, uri-http, uri-https, uri-ldap, uri-ldaps
  • use closer-mop for defclass
  • manually added uri-p, urn-p, uri-file-p, uri-ftp-p, uri-http-p, uri-https-p, uri-ldap-p, uri-ldaps-p
  • remove %make-uri, %make-urn, %make-uri-ftp, %make-uri-file, %make-uri-ftp since its only used once respectively
  • add/updated constructors: make-basic-uri, make-urn, make-uri-file, make-uri-ftp, make-uri-http, make-uri-https, make-uri-ldap, make-uri-ldaps
  • add type declarations to changed functions

Questions:

  • The tests are succeeding. Should more tests be added (e.g. with change-class?)?
  • Most slots are initialized to nil, to avoid unbound slot error.
    Is that desirable?
  • should most slots have an accessor or reader only?
  • urn nid and nss are not typed
    (was not sure if they are string only or also other types allowed)

#58 @genworks

- convert structs to classes: uri, urn, uri-ftp, uri-file,
  uri-http, uri-https, uri-ldap, uri-ldaps
- use closer-mop for defclass
- manually added uri-p, urn-p, uri-file-p, uri-ftp-p,
  uri-http-p, uri-https-p, uri-ldap-p, uri-ldaps-p
- remove %make-uri, %make-urn, %make-uri-ftp, %make-uri-file, %make-uri-ftp since its only used once respectively
- add/updated constructors: make-basic-uri, make-urn, make-uri-file, make-uri-ftp, make-uri-http, make-uri-https, make-uri-ldap, make-uri-ldaps
- add type declarations to changed functions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant