Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paket template comment #991

Merged
merged 3 commits into from
Aug 18, 2015
Merged

Conversation

MorganPersson
Copy link
Contributor

Comments in paket.template files by using #.

@forki
Copy link
Member

forki commented Aug 17, 2015

Could you please also add // as comments? IIRC we support both in dependencies file

@@ -224,11 231,12 @@ module internal TemplateFile =
let private fromReg = Regex("from (?<from>.*)", RegexOptions.Compiled)
let private toReg = Regex("to (?<to>.*)", RegexOptions.Compiled)
let private isExclude = Regex("\s*!\S", RegexOptions.Compiled)

let private isComment = Regex("\s*#", RegexOptions.Compiled)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you already have the same/similar regex above

@MorganPersson
Copy link
Contributor Author

support for // added

@forki
Copy link
Member

forki commented Aug 18, 2015

very cool. thx

forki added a commit that referenced this pull request Aug 18, 2015
@forki forki merged commit 0cc3bea into fsprojects:master Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants