Selective update resolves the graph for selected package #957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SelectiveUpdate does not resolve the whole dependency graph, hence it needs the version constraint of the dependencies in paket.lock to update paket.lock correctly.
|
selective update should unpin all transitive package dependencies right now. do you have a repro case? |
|
OK, seems you are right and we have a regression. I tested the following deps file: with lock file: and it didn't update after |
| @@ -47,12 47,12 @@ let ``should parse lock file``() = | |||
| packages.[1].Source |> shouldEqual PackageSources.DefaultNugetSource | |||
| packages.[1].Name |> shouldEqual (PackageName "Castle.Windsor-log4net") | |||
| packages.[1].Version |> shouldEqual (SemVer.Parse "3.3") | |||
| packages.[1].Dependencies |> shouldEqual (Set.ofList [PackageName "Castle.Windsor", VersionRequirement.AllReleases, []; PackageName "log4net", VersionRequirement.AllReleases, []]) | |||
| packages.[1].Dependencies |> shouldEqual (Set.ofList [PackageName "Castle.Windsor", VersionRequirement(Minimum(SemVer.Parse "2.0"), PreReleaseStatus.No), []; PackageName "log4net", VersionRequirement(Minimum(SemVer.Parse "1.0"), PreReleaseStatus.No), []]) | |||
|
mhm from looking at the existing code I'm not that sure anymore that this worked before. maybe it only worked in my dreams. so:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior of selective update (update specifying a package).
The current behavior is to pin the version for all packages, except the one specified, and resolve the whole graph.
This would cause the dependencies of the specified package to be pinned and the package would not be updated if it requires that one or more dependencies need to be updated as well.
For example:
Castle.Core-log4net 3.2.0depends onCastle.Core >= 3.2.0Castle.Core-log4net 3.3.3depends onCastle.Core >= 3.3.3If I try to update
Castle.Core-log4netfrom3.2.0to3.3.3, it would not succeed becauseCastle.Coreis pinned to3.2.0.This PR only resolve the specified package graph.