Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings for dependent packages should be respected #919

Merged

Conversation

baronfel
Copy link
Contributor

@baronfel baronfel commented Jul 8, 2015

Consider a paket.dependencies file:

source api.nuget.org/etc/etc

nuget A
nuget B content: none

and a paket.references file in a project that just specifies a dependency on A

Now imagine that B is a dependency of A

Right now on install for a project we take the full set of packages [A,B] and extract from it the top-level dependencies of the project, resulting in [A]. We then configure the installSettings for this dependency, which in this case is the empty InstallSettings.

After we build the top-level map we augment it with the n-tier dependencies of each top-level dependency, and use the parent's configured InstallSettings only. This results in an install of package B where the content: none directive is not honored.

This pull request resolves the settings for the n-tier dependencies in a similar manner to the top-level dependencies, while allowing any top-level dependency settings to override the settings configured for the lower-level package if any are present.

@forki
Copy link
Member

forki commented Jul 13, 2015

very cool thx.

forki added a commit that referenced this pull request Jul 13, 2015
…ndencies

settings for dependent packages should be respected
@forki forki merged commit 8612713 into fsprojects:master Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants