Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds PowerShell argument tab completion for Paket-Add #887

Merged
merged 4 commits into from
Jun 21, 2015

Conversation

ctaggart
Copy link
Contributor

fix #873
fix exception handling
add some positional params

image

image

image
The list of versions should be sorted the other way. See #886.

Cameron Taggart added 2 commits June 20, 2015 11:39
fix fsproject/Paket#873
fix exception handling
add some positional params
@ctaggart
Copy link
Contributor Author

Last issue before this is mergable is that this is causing things to lock up.

Paket-Add -NuGet

@ctaggart ctaggart changed the title WIP: adds PowerShell argument tab completion for Paket-Add adds PowerShell argument tab completion for Paket-Add Jun 21, 2015
@ctaggart
Copy link
Contributor Author

This is good to go.

@ctaggart
Copy link
Contributor Author

I'm going to post more screenshots. I'm pretty happy with this. I'm looking forward to announcing Paket.PowerShell soon.

image

image

As soon as get this flipped: :)
image

@forki
Copy link
Member

forki commented Jun 21, 2015

Will fix later today, but needs time until the chocolatey people release it
On Jun 21, 2015 8:56 AM, "Cameron Taggart" [email protected] wrote:

I'm going to post more screenshots. I'm pretty happy with this. I'm
looking forward to announcing Paket.PowerShell soon.

[image: image]
https://cloud.githubusercontent.com/assets/80104/8270766/be8148ea-17a7-11e5-8779-0e3c0b9a8854.png

[image: image]
https://cloud.githubusercontent.com/assets/80104/8270767/d163c4c4-17a7-11e5-93ac-4392e8f9b327.png

As soon as get this flipped: :)
[image: image]
https://cloud.githubusercontent.com/assets/80104/8270771/eaf9361c-17a7-11e5-90c5-49c8a86baa68.png


Reply to this email directly or view it on GitHub
#887 (comment).

@ctaggart
Copy link
Contributor Author

In my blog, I'll talk about adding other chocolatey sources like the NuGet Gallery to stay up-to-date.

choco source list
choco source add -n=nuget -s=https://www.nuget.org/api/v2

@forki
Copy link
Member

forki commented Jun 21, 2015

Nice. And I read they can also white-list tools. Maybe they will white-list
paket one day.
On Jun 21, 2015 9:05 AM, "Cameron Taggart" [email protected] wrote:

In my blog, I'll talk about adding other chocolatey sources like the NuGet
Gallery to stay up-to-date.

choco source list
choco source add -n=nuget -s=https://www.nuget.org/api/v2


Reply to this email directly or view it on GitHub
#887 (comment).

@@ -25,7 25,10 @@ module PaketPs =
async {
try
do! Async.SwitchToNewThread()
do! computation
try
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the try with here, an exception kills the started thread, which kills the powershell thread which kills powershell. It is important.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add this as a comment in the code there.

if (-not $global:options) { $global:options = @{CustomArgumentCompleters = @{};NativeArgumentCompleters = @{}}}

$global:options['CustomArgumentCompleters']['Paket-Add:NuGet'] = $findPackages
$global:options['CustomArgumentCompleters']['Paket-Add:Version'] = $findPackageVersions
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More argument tab completers can be added following this pattern. It must be done in PowerShell. The output of another command is used to do the tab completion.

forki added a commit that referenced this pull request Jun 21, 2015
adds PowerShell argument tab completion for Paket-Add
@forki forki merged commit 18f5cb4 into fsprojects:master Jun 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Paket.PowerShell Argument Tab Completion
2 participants