Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclusion syntax for paket.template files #882

Merged

Conversation

devboy
Copy link
Contributor

@devboy devboy commented Jun 19, 2015

PR for #880

  • parses -- to exclude files
  • change to !* pattern
  • disallow the space to avoid ambiguity
  • apply pattern/globs during packaging
  • when fixing a relative path (..) append \ to windows drive (C:)
  • how to exclude entire directory

@forki
Copy link
Member

forki commented Jun 22, 2015

is this ready to merge?

@devboy
Copy link
Contributor Author

devboy commented Jun 22, 2015

Will push the latest fixes after lunch ;)

@devboy devboy force-pushed the feature/exclusion-syntax-template-files branch from be5e406 to 65e8edd Compare June 22, 2015 12:53
@devboy
Copy link
Contributor Author

devboy commented Jun 22, 2015

Apart from not matching against directories (!myDir) where you'd have to use (!myDir/*.*) everything should be in. It would probably be enough to fix that in Fake.Globbing without touching this code.

@forki
Copy link
Member

forki commented Jun 22, 2015

it's also important to have a bit of documentation for this.

@devboy
Copy link
Contributor Author

devboy commented Jun 22, 2015

👍

@devboy devboy force-pushed the feature/exclusion-syntax-template-files branch from 7eda764 to 9b5c712 Compare June 22, 2015 13:20
@devboy
Copy link
Contributor Author

devboy commented Jun 22, 2015

Is the documentation sufficient?

@forki
Copy link
Member

forki commented Jun 22, 2015

Yep thanks a lot

forki added a commit that referenced this pull request Jun 22, 2015
…-files

Exclusion syntax for paket.template files
@forki forki merged commit b63e370 into fsprojects:master Jun 22, 2015
@forki
Copy link
Member

forki commented Jun 22, 2015

very cool. thanks a lot.

released in paket 1.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants