Copy paket exe to cwd on init #853
Conversation
Renamed DownloadAssemblies to Releases and added functions to download bootstrapper, bootstrapper and targets and a custom list of files.
|
/cc @theimowski could you please take a short look? |
| currentVersion < latest | ||
|
|
||
| let downloadLatestVersionOf files destDir = | ||
| let releasesUrl = "https://api.github.com/repos/fsprojects/Paket/releases"; |
There was a problem hiding this comment.
please move this into the Constants module
|
apart from the comments, LGTM |
Renamed notExistsOrIsNewer to doesNotExistOrIsNewer (it was late last night ;))
|
I moved the URLs and other stuff into the Constants module and added comments on the functions. @theimowski what exactly did you mean by "inline these and above functions"? Remove the downloadLatestBootstrapper* functions and only call downloadLatestVersionOf? |
|
I think he meant, that you just remove the functions and use the code directly without a separate function |
|
But this would be unnecessary duplication? The way it is now the downloadLatestVersionOf function can be used to easily extend the functionality of the module later for other files. |
|
Ok. Thanks a lot
|
|
And both other functions are used in the publicAPI module. Or do I still get it wrong? |
|
thx. released in 1.10 |
|
Ok nvmd, I've not looked at the call sites for those functions - they just seemed extraordinary at first glance |
As discussed in Paket.Atom issue 14 Paket should download the paket.bootstrapper into the .paket dir on init. I created a new module Paket.Releases which handles downloading the latest versions of paket.exe, the bootstrapper and paket.targets.