Protect paket.exe from incomplete github downloads #788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the github HTTP response writes directly to the target paket.exe, but the the download fails until it completes it left a defect paket.exe. So lets download to a temporary file and only copy it to the target location if the download was successful. This is the same behavior as the nuget download strategy.
|
|
forki
added a commit
that referenced
this pull request
Apr 20, 2015
Protect paket.exe from incomplete github downloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the github HTTP response writes directly to the target paket.exe, but if the download fails until it completes it left a defect paket.exe. So lets download to a temporary file and only copy it to the target location if the download was successful.
This is the same behavior as the nuget download strategy.