Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve config file formatting with indented binding redirects #769

Merged
merged 2 commits into from
Apr 12, 2015
Merged

Improve config file formatting with indented binding redirects #769

merged 2 commits into from
Apr 12, 2015

Conversation

Stift
Copy link
Contributor

@Stift Stift commented Apr 11, 2015

unitil now paket puts all binding redirects in one line which is very annoying when some binding is changing. With this pr we should improve the formatting in the config file and make it easier for the users to see what changes when they commit the changed config files.

@forki
Copy link
Member

forki commented Apr 12, 2015

Cool.
There was already an issue for this somewhere. @dnauck

@forki
Copy link
Member

forki commented Apr 12, 2015

what about already existig xml. do we reformat that?

@Stift
Copy link
Contributor Author

Stift commented Apr 12, 2015

Yes, but only the part in the runtime/configuration/assemblyBinding. Any problem with that?
The root cause of the problem is, that we load the existing config with PreserveWhitespaces which prevents reformatting on adding new XElements.

@forki
Copy link
Member

forki commented Apr 12, 2015

Ok if we only reformat assembly bindings then it should be fine.

@agross @dnauck?
On Apr 12, 2015 10:26 AM, "Christian" [email protected] wrote:

Yes, but only the part in the runtime/configuration/assemblyBinding. Any
problem with that?
The root cause of the problem is, that we load the existing config with
PreserveWhitespaces which prevents reformatting on adding new XElements.

—
Reply to this email directly or view it on GitHub
#769 (comment).

forki added a commit that referenced this pull request Apr 12, 2015
@forki
Merge pull request #769 from Stift/IndentAssemblyBindingRedirects
0e40547 
Improve config file formatting with indented binding redirects
@forki forki merged commit 0e40547 into fsprojects:master Apr 12, 2015
@forki
Copy link
Member

forki commented Apr 12, 2015

owl

@agross
Copy link
Contributor

agross commented Apr 12, 2015

👍

@Stift Stift deleted the IndentAssemblyBindingRedirects branch April 12, 2015 09:12
@Stift Stift restored the IndentAssemblyBindingRedirects branch April 12, 2015 09:12
@Stift Stift deleted the IndentAssemblyBindingRedirects branch April 12, 2015 09:12
@isaacabraham
Copy link
Contributor

Lovely

@Stift
Copy link
Contributor Author

Stift commented Apr 12, 2015

line commits with 10k are a little bit strange when unexperienced devs see that. hope it helps also others.

@dnauck
Copy link
Contributor

dnauck commented Apr 13, 2015

@forki this was issue #597

I'll test this new stuff today.

@dnauck dnauck mentioned this pull request Apr 16, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Stift @forki @agross @isaacabraham @dnauck