Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boostrapper download without nuget exe and switch bootstrapper to .net 4.5 #734

Merged
merged 4 commits into from
Apr 8, 2015
Merged

Boostrapper download without nuget exe and switch bootstrapper to .net 4.5 #734

merged 4 commits into from
Apr 8, 2015

Conversation

Stift
Copy link
Contributor

@Stift Stift commented Mar 28, 2015

The previous approach for the nuget fallback for the bootstrapper used the nuget.exe to accomplish it tasks.
I changed the fallback behaviour for the bootstrapper with the following new features

  • change project version to .Net 4.5 (to unzip via Framework)
  • do not use nuget.exe anymore
  • download package directly via nuget API
  • use evaluated parameters for prerelease or specified version

@forki
Copy link
Member

forki commented Mar 28, 2015

very cool.
could you please add a --prefer-nuget switch, which changes the order?
I'm sure @vasily-kirichenko would like it, since sometime github download is slow.

@Stift
Copy link
Contributor Author

Stift commented Mar 28, 2015

Very nice idea. Will do that.

@Stift
new bootstrapper parameter --prefer-nuget to prefer nuget over github
c6dfa2d 
- refactored download pattern with strategies
- command parameter evaluation separated
@Stift
Copy link
Contributor Author

Stift commented Mar 29, 2015

Ok. I introduced now the parameter --prefer-nuget which prefers nuget over github.
Default behaviour: github (fallback: nuget)
--prefer-nuget behaviour: nuget (fallback: github)

I hope this pleases all the needs.
igbe3a8tavn0q

@Stift
Copy link
Contributor Author

Stift commented Mar 29, 2015

Just found a bug in version parsing from nuget. Will provide a fix in a minute

@Stift
fixing prerelease detection from nuget
e642f01 
parsing nuget versions with SemVer
SemVer impl transformed from fs in paket.core
@Stift
Copy link
Contributor Author

Stift commented Mar 29, 2015

There was an issue with the SemVer stuff. Should be fixed by now

@forki
Copy link
Member

forki commented Mar 30, 2015

cool thanks. I just have to wait a bit until we have the other .NET 4.5 stuff ready.

@Stift
Copy link
Contributor Author

Stift commented Mar 30, 2015

Ok. I'll wait until then with other improvements, I'll have in my pipeline for the bootstrapper.

@forki forki merged commit e642f01 into fsprojects:master Apr 8, 2015
@forki
Copy link
Member

forki commented Apr 8, 2015

Thanks. It's now part of 0.39 alpha.

@Stift
Copy link
Contributor Author

Stift commented Apr 8, 2015

Very nice. You are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Stift @forki