Use .NET 4.5's version of ZipArchive - references #729 #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | :? Ionic.Zip.BadCrcException as exn -> | ||
| traceWarnfn "Bad Crc during unzipping %s in %s %A: %s" e.FileName name version exn.Message | ||
| | exn -> failwithf "Error during unzipping %s in %s %A: %s" e.FileName name version exn.Message | ||
| ZipFile.ExtractToDirectory(fileName, targetFolder) |
There was a problem hiding this comment.
Is overwrite silently the default behavior? And how about Crc exn? Not thrown anymore?
|
Lgtm |
|
@mavnn most things work, but nuget package explorer tells me about missing manifest in generated package. any ideas? |
|
I tried to diff the packages, but I don't see any differences. I'm stuck. |
Merged
- refactored download pattern with strategies - command parameter evaluation separated
parsing nuget versions with SemVer SemVer impl transformed from fs in paket.core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This chance has possibly big implications.
Please review it and then I can create an prerelease version for broader testing.
/cc @theimowski @mexx @mavnn @Vidarls