Fixes re-ordering problem with files #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -129,8 129,6 @@ type ProjectFile = | |||
| node.ParentNode.RemoveChild(node) |> ignore | |||
|
|
|||
| member this.UpdateFileItems(fileItems : FileItem list, hard) = | |||
| this.DeletePaketNodes("Compile") | |||
There was a problem hiding this comment.
we would never deinstall thing if we don't delete.
There was a problem hiding this comment.
Humm, So the InstallProcess.InstallIntoProjects also removes stuff? I guess by virtue of the fact that if it isn't included in that file list then it shouldn't be there? Correct?
There was a problem hiding this comment.
the idea was: remove all paket stuff from a fsproj file and add it again. since we can't know if someone remove a package.
|
mhm. I think it will need a bit of testing from my side. Will try to look into it tomorrow. |
|
so this only applies to the content file items, right? |
|
thanks. let's see if it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have had problems in a number of projects where I have re-ordered the files in the project, for one reason or another. However when I run
paket updatethere are certain situations where this order isn't maintained. For example,Before running
paket updateAfter running
paket updateThis fix prevents this re-ordering from happening by retaining the paket Compile and Content elements in place when
ProjectFile.UpdateFileItems. I'm not a 100% sure this is the correct fix, but it was the most simply thing I could see to do with out changingUpdateFilessignificantly.