Rewrite template file parsing #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It runs so fast that the colors don't even start fading out :-) |
|
@tpetricek ha :). I rebuilt before realising I wanted a benchmark! |
|
Nice! |
| @@ -86,60 160,29 @@ module internal TemplateFile = | |||
| | ProjectInfo(core, optional) -> ProjectInfo(core, { optional with ReleaseNotes = Some releaseNotes }) | |||
| { templateFile with Contents = contents } | |||
|
|
|||
| let private (!<) prefix lines = | |||
There was a problem hiding this comment.
I added a new one to ensure balance in the force.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #625 and tests for #659
Before:
After:
It would be easier to smug about the two order of magnitude improvement if I hadn't written the original :)