Handle transient dependencies better in pack command #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| let dep = | ||
| match Map.tryFind np.Name dependencies.DirectDependencies with | ||
| | Some direct -> direct | ||
| // If it's a transiant dependency set |
|
which case are we fixing here? |
|
This fixes a "not found" exception when a package listed in It came up for me in a solution where one project relied on package A, which depends on package B - and another project relied directly on package B. Package B was removed from |
| |> List.map (fun np -> np.Name.Id, dependencies.DirectDependencies.[np.Name]) | ||
| |> List.map (fun np -> | ||
| let dep = | ||
| match Map.tryFind np.Name dependencies.DirectDependencies with |
There was a problem hiding this comment.
do we need to go via NormalizedPackageName or did we get both sides in correct casing?
There was a problem hiding this comment.
Ah... honestly not sure? I suppose we'd have to normalize both sides at that point; I'd take your advice as to whether it's needed.
forki
added a commit
that referenced
this pull request
Feb 24, 2015
Handle transient dependencies better in pack command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.