Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paket.lock beautification for HTTP specs #571

Merged
merged 1 commit into from
Jan 28, 2015

Conversation

sergey-tihon
Copy link
Member

#553

paket.dependencies:

http http://www.frijters.net/ikvmbin-8.0.5449.0.zip
http http://nlp.stanford.edu/software/stanford-corenlp-full-2014-10-31.zip
http http://nlp.stanford.edu/software/stanford-ner-2014-10-26.zip
http http://nlp.stanford.edu/software/stanford-parser-full-2014-10-31.zip
http http://nlp.stanford.edu/software/stanford-postagger-full-2014-10-26.zip
http http://nlp.stanford.edu/software/stanford-segmenter-2014-10-26.zip

Old paket.lock:

HTTP
  remote: http://www.frijters.net/ikvmbin-8.0.5449.0.zip
  specs:
    ikvmbin-8.0.5449.0.zip
  remote: http://nlp.stanford.edu/software/stanford-corenlp-full-2014-10-31.zip
  specs:
    stanford-corenlp-full-2014-10-31.zip
  remote: http://nlp.stanford.edu/software/stanford-ner-2014-10-26.zip
  specs:
    stanford-ner-2014-10-26.zip
  remote: http://nlp.stanford.edu/software/stanford-parser-full-2014-10-31.zip
  specs:
    stanford-parser-full-2014-10-31.zip
  remote: http://nlp.stanford.edu/software/stanford-postagger-full-2014-10-26.zip
  specs:
    stanford-postagger-full-2014-10-26.zip
  remote: http://nlp.stanford.edu/software/stanford-segmenter-2014-10-26.zip
  specs:
    stanford-segmenter-2014-10-26.zip

New paket.lock:

HTTP
  remote: http://www.frijters.net
  specs:
    ikvmbin-8.0.5449.0.zip (/ikvmbin-8.0.5449.0.zip)
  remote: http://nlp.stanford.edu
  specs:
    stanford-corenlp-full-2014-10-31.zip (/software/stanford-corenlp-full-2014-10-31.zip)
    stanford-ner-2014-10-26.zip (/software/stanford-ner-2014-10-26.zip)
    stanford-parser-full-2014-10-31.zip (/software/stanford-parser-full-2014-10-31.zip)
    stanford-postagger-full-2014-10-26.zip (/software/stanford-postagger-full-2014-10-26.zip)
    stanford-segmenter-2014-10-26.zip (/software/stanford-segmenter-2014-10-26.zip)

@sergey-tihon
Copy link
Member Author

This PR is definitely needs review

forki added a commit that referenced this pull request Jan 28, 2015
paket.lock beautification for HTTP specs
@forki forki merged commit 596a073 into fsprojects:master Jan 28, 2015
@forki
Copy link
Member

forki commented Jan 28, 2015

thanks dude, I'll check it out

@forki
Copy link
Member

forki commented Jan 28, 2015

please test 0.26 alpha versions

@sergey-tihon
Copy link
Member Author

I works in all my cases

@JonCanning
Copy link
Contributor

This isn't working for me, I'm referencing a raw gist. The bracket gets included in the folder structure, and the structure seems to be duplicated within that.

@forki
Copy link
Member

forki commented Feb 5, 2015

can you please gieve mini repro so that we can fix it.

@JonCanning
Copy link
Contributor

http https://gist.githubusercontent.com/JonCanning/37769e635aaece6dcef3/raw/adffa54dd02f94e5b06667700ef44e1a5feded73/paket.txt paket.txt

If I remove the file extension from the link it works

@forki
Copy link
Member

forki commented Feb 5, 2015

@sergey-tihon can you try to fix this?

@forki
Copy link
Member

forki commented Feb 5, 2015

I tried the following:

paket.dependencies:

http https://gist.githubusercontent.com/JonCanning/37769e635aaece6dcef3/raw/adffa54dd02f94e5b06667700ef44e1a5feded73/paket.txt

paket.references:

File:paket.txt .

running paket update gives paket.lock:

HTTP
  remote: https://gist.githubusercontent.com
  specs:
    paket.txt (/JonCanning/37769e635aaece6dcef3/raw/adffa54dd02f94e5b06667700ef44e1a5feded73/paket.txt)

and fsproj-file got:

    <Content Include="..\..\paket-files\gist.githubusercontent.com\paket.txt">
      <Paket>True</Paket>
      <Link>paket.txt</Link>
    </Content>

LGTM

@JonCanning
Copy link
Contributor

It's when you specify a filename after the url that it goes wrong

@forki
Copy link
Member

forki commented Feb 5, 2015

but do we support that? http://fsprojects.github.io/Paket/http-dependencies.html

what should it do?

@JonCanning
Copy link
Contributor

I was looking at the example here:

http://fsprojects.github.io/Paket/dependencies-file.html

I assumed that it would allow me to call the file something different locally

@forki
Copy link
Member

forki commented Feb 5, 2015

  1. Ouch. I have to test if this still works. Thanks for reporting.
  2. I think this would be a new feature request. I think it makes sense.

@sergey-tihon
Copy link
Member Author

As I know we support it for services that does not have file name in url, like www.fssnip.net
https://github.com/fsprojects/Paket/blob/master/tests/Paket.Tests/DependenciesFile/ParserSpecs.fs#L276-L277

I cannot reproduce it even with new file name. =(
paket.dependencies:

http https://gist.githubusercontent.com/JonCanning/37769e635aaece6dcef3/raw/adffa54dd02f94e5b06667700ef44e1a5feded73/paket.txt paket.txt

paket.lock:

HTTP
  remote: https://gist.githubusercontent.com
  specs:
    paket.txt (/JonCanning/37769e635aaece6dcef3/raw/adffa54dd02f94e5b06667700ef44e1a5feded73/paket.txt)

File structure:
image

@JonCanning
Copy link
Contributor

Ah, it seems to be paket install that does it

@forki
Copy link
Member

forki commented Feb 5, 2015

install doesn't work with http depenencies at the moment - #532

you have to run update. Subsequent installs will work.

@JonCanning
Copy link
Contributor

It's the subsequent install that creates the mangled path

capture

@forki
Copy link
Member

forki commented Feb 5, 2015

woupsi. I can reproduce this.

@sergey-tihon: just try install after update and it will fail.

@forki
Copy link
Member

forki commented Feb 6, 2015

sorry about playing pingpong here. could you please test with 0.27.0-alpha006?

@JonCanning
Copy link
Contributor

update writes:

<Content Include="paket-files\gist.githubusercontent.com\paket.txt">

subsequent install writes:

<Content Include="paket-files\gist.githubusercontent.com\gist.githubusercontent.com\paket.txt">

and a duplicate appears in paket-files along with a paket.dependencies which contains the html for the github gist page!?

@forki
Copy link
Member

forki commented Feb 6, 2015

thanks I think this is fixed in 0.27.0-alpha007.

@JonCanning
Copy link
Contributor

That's better, still got the dependencies file appearing on install, is that a problem?

@forki
Copy link
Member

forki commented Feb 6, 2015

what do you mean?

@JonCanning
Copy link
Contributor

The subsequent install creates a paket.dependencies file next to the paket.txt file

@forki
Copy link
Member

forki commented Feb 6, 2015

that's actualy not bad, but I will check why this happens in this case

@forki
Copy link
Member

forki commented Feb 6, 2015

oh I take that back. The dependencies file contains content (strange html). so it's probably created because the server doesn't throw 404 on the resource. funny

will investigate

@forki
Copy link
Member

forki commented Feb 6, 2015

thanks for reporting this stuff. that's very valuable.
I pushed a new prerelease.

@JonCanning
Copy link
Contributor

That's working for me, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants