-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
paket.lock beautification for HTTP specs #571
Conversation
This PR is definitely needs review |
paket.lock beautification for HTTP specs
thanks dude, I'll check it out |
please test 0.26 alpha versions |
I works in all my cases |
This isn't working for me, I'm referencing a raw gist. The bracket gets included in the folder structure, and the structure seems to be duplicated within that. |
can you please gieve mini repro so that we can fix it. |
http https://gist.githubusercontent.com/JonCanning/37769e635aaece6dcef3/raw/adffa54dd02f94e5b06667700ef44e1a5feded73/paket.txt paket.txt If I remove the file extension from the link it works |
@sergey-tihon can you try to fix this? |
I tried the following:
running
and fsproj-file got:
LGTM |
It's when you specify a filename after the url that it goes wrong |
but do we support that? http://fsprojects.github.io/Paket/http-dependencies.html what should it do? |
I was looking at the example here: http://fsprojects.github.io/Paket/dependencies-file.html I assumed that it would allow me to call the file something different locally |
|
As I know we support it for services that does not have file name in url, like I cannot reproduce it even with new file name. =(
|
Ah, it seems to be paket install that does it |
install doesn't work with http depenencies at the moment - #532 you have to run update. Subsequent installs will work. |
woupsi. I can reproduce this. @sergey-tihon: just try install after update and it will fail. |
sorry about playing pingpong here. could you please test with 0.27.0-alpha006? |
update writes:
subsequent install writes:
and a duplicate appears in paket-files along with a paket.dependencies which contains the html for the github gist page!? |
thanks I think this is fixed in 0.27.0-alpha007. |
That's better, still got the dependencies file appearing on install, is that a problem? |
what do you mean? |
The subsequent install creates a paket.dependencies file next to the paket.txt file |
that's actualy not bad, but I will check why this happens in this case |
oh I take that back. The dependencies file contains content (strange html). so it's probably created because the server doesn't throw 404 on the resource. funny will investigate |
thanks for reporting this stuff. that's very valuable. |
That's working for me, thanks |
#553
paket.dependencies
:Old
paket.lock
:New
paket.lock
: